search

hypertrace / javaagent

Hypertrace OpenTelemetry Java agent with payload/body and headers data capture.
Apache License 2.0
30 stars 15 forks source link

Fix failing snyk running on forks #325

Closed pavolloffay closed 3 years ago

pavolloffay commented 3 years ago

The issue is that the SNYK_TOKEN is not added to the build. It worked in the ht-service https://github.com/hypertrace/hypertrace-service/runs/2876248502#step:4:5

pavolloffay commented 3 years ago

The solution is to use pull_request_target conf in the workflow config e.g. https://github.com/hypertrace/hypertrace-service/blob/main/.github/workflows/pr-build.yml#L6.

This makes the secrets available to the fork builds https://docs.github.com/en/actions/reference/events-that-trigger-workflows

pavolloffay commented 3 years ago

@ryandens see now https://github.com/hypertrace/javaagent/pull/323 is passing.