search

hypertrace / javaagent

Hypertrace OpenTelemetry Java agent with payload/body and headers data capture.
Apache License 2.0
30 stars 15 forks source link

Remove CCI and add release GHA release workflow #333

Closed pavolloffay closed 3 years ago

pavolloffay commented 3 years ago

Related to https://github.com/hypertrace/hypertrace/issues/144

Remove deprecated CCI release job to GHA.

I haven't tested if the credentials are correct, hence this PR might need some more love after is merged and release triggered.

ryandens commented 3 years ago

Fantastic, really excited about this! 🎉 I recently did something like this on a different closed-source projects. One of things I found useful to do prior to merging was temporarily adding a step to the PR pipeline with the gradle task publishToMavenLocal to make sure I pulled in all of the signing key properties were correct and produced a valid signature. Additionally, to prevent some issues popping up when we go to release this next, we could test the publish task in GHA by simply publishing to a staging repo, but without the closeAndReleaseRepository task. When we've verified it works properly, we can simply manually drop the staging repo in nexus and remove the steps used to test the publish workflow. ultimately, nothing will perfectly test publishing until we actually publish, but I think doing something like I described would help us reduce risk.

ryandens commented 3 years ago

Nit: could you also update the badge in the README to point to GHA rather than CircleCI? Additionally, I believe the bullet points describing how to add an SSH key for CircleCI in RELEASE.md#Configuration are no longer necessary and can be deleted. Mainly, I'm just looking to cleanup references to CircleCI.

pavolloffay commented 3 years ago

I will update docs, however I don't have the secrets for the local dry run. Would you like to try it yourself?

ryandens commented 3 years ago

I will update docs, however I don't have the secrets for the local dry run. Would you like to try it yourself?

I don't think I'll have the time to get to it today, and I wrote this suggestion before seeing your message about cutting a patch release to test it out, that's probably a better way to go! Thanks for the PR 😃

pavolloffay commented 3 years ago

I will merge, cut the release, and hope 😅