For some reason, actions that use the pull_request_target attribute causes the deefault checkout destination of the checkout action to be whatever is currently the head of origin/main. This can allow build/test errors from PRs make it into the main branch before failing (but not allowing them to be released). An example PR is #337. Note, the GHA all passed on commit e9d665c. However, note the checkout action step for that PR here. It checks out the commit from what was currently the head of origin/main (ref 4a920915c55e3d0e86806482bec736554315100b) and caused the PR to pass all builds, only to have the main build fail once the PR was merged. This resulted in us needing to quickly patch in PR #338.
Testing
Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested helm chart locally.
Checklist:
[ ] My changes generate no new warnings
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] Any dependent changes have been merged and published in downstream modules
Documentation
Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.
Description
For some reason, actions that use the
pull_request_targetattribute causes the deefault checkout destination of the checkout action to be whatever is currently the head oforigin/main. This can allow build/test errors from PRs make it into the main branch before failing (but not allowing them to be released). An example PR is #337. Note, the GHA all passed on commit e9d665c. However, note the checkout action step for that PR here. It checks out the commit from what was currently the head oforigin/main(ref4a920915c55e3d0e86806482bec736554315100b) and caused the PR to pass all builds, only to have the main build fail once the PR was merged. This resulted in us needing to quickly patch in PR #338.Testing
Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested helm chart locally.
Checklist:
Documentation
Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.