hypertrace / javaagent

Hypertrace OpenTelemetry Java agent with payload/body and headers data capture.
Apache License 2.0
28 stars 14 forks source link

ENG-17140 Ensure requests can be filtered because of method body #364

Closed bradAtTraceable closed 2 years ago

bradAtTraceable commented 2 years ago

Description

Please include a summary of the change, motivation and context.

Testing

Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested helm chart locally.

Checklist:

Documentation

Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.

bradAtTraceable commented 2 years ago

The purpose of this test is to ensure that the Filter receives the contents of an HTTP request body, so that it can block the request, if required. Previously, the request body was only being passed to the filter if the reader of the request body received an indication that the end-of-stream was reached. However, in some cases, the reader would stop reading the request body without seeing the normal end-of-stream indication, and the filter would not be called.

shashank11p commented 2 years ago

@bradAtTraceable Some smoke tests are failing. Please update the tests as well :)