hypertrace / javaagent

Hypertrace OpenTelemetry Java agent with payload/body and headers data capture.
Apache License 2.0
33 stars 15 forks source link

upgrade otel version to 1.24 #378

Closed shashank11p closed 1 year ago

shashank11p commented 1 year ago

Description

Please include a summary of the change, motivation and context.

Testing

Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested helm chart locally.

Checklist:

Documentation

Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.

tyroneyu commented 1 year ago

Aside from the commented code Tim pointed out, lgtm.

shashank11p commented 1 year ago

Removed jaxrs instrumentation since it did not provide any additional value to us. The client spans are already being created by apache-httpclient instrumentation. And the passing tests show that we will be able to capture all that we need without this extra instrumentation as well