search

hypfvieh / dbus-java

Improved version of java DBus library provided by freedesktop.org (https://dbus.freedesktop.org/doc/dbus-java/)
https://hypfvieh.github.io/dbus-java/
MIT License
185 stars 73 forks source link

Failure in compiling tests #151

Closed poeschel closed 3 years ago

poeschel commented 3 years ago

Current Version in master branch fails compiling the tests. More specifically: `[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.1:testCompile (default-testCompile) on project dbus-java: Compilation failure: Compilation failure:

[ERROR] /home/larsi/projekte/dbus-java/dbus-java/src/test/java/org/freedesktop/dbus/test/MarshallingTest.java:[32,38] cannot find symbol [ERROR] symbol: class AbstractBaseTest [ERROR] /home/larsi/projekte/dbus-java/dbus-java/src/test/java/org/freedesktop/dbus/test/MarshallingTest.java:[78,117] cannot find symbol [ERROR] symbol: method getClass() [ERROR] location: class org.freedesktop.dbus.test.MarshallingTest [ERROR] /home/larsi/projekte/dbus-java/dbus-java/src/test/java/org/freedesktop/dbus/test/MarshallingTest.java:[78,211] cannot find symbol [ERROR] symbol: method getClass() [ERROR] location: class org.freedesktop.dbus.test.MarshallingTest [ERROR] /home/larsi/projekte/dbus-java/dbus-java/src/test/java/org/freedesktop/dbus/test/MarshallingTest.java:[78,308] cannot find symbol [ERROR] symbol: method getClass() [ERROR] location: class org.freedesktop.dbus.test.MarshallingTest [ERROR] /home/larsi/projekte/dbus-java/dbus-java/src/test/java/org/freedesktop/dbus/test/MarshallingTest.java:[84,9] cannot find symbol [ERROR] symbol: method assertTrue(boolean,java.lang.String) [ERROR] location: class org.freedesktop.dbus.test.MarshallingTest [ERROR] /home/larsi/projekte/dbus-java/dbus-java/src/test/java/org/freedesktop/dbus/test/MarshallingTest.java:[86,9] cannot find symbol [ERROR] symbol: method assertTrue(boolean,java.lang.String) [ERROR] location: class org.freedesktop.dbus.test.MarshallingTest [ERROR] /home/larsi/projekte/dbus-java/dbus-java/src/test/java/org/freedesktop/dbus/test/MarshallingTest.java:[100,9] cannot find symbol [ERROR] symbol: method assertTrue(boolean,java.lang.String) [ERROR] location: class org.freedesktop.dbus.test.MarshallingTest [ERROR] /home/larsi/projekte/dbus-java/dbus-java/src/test/java/org/freedesktop/dbus/test/MarshallingTest.java:[102,9] cannot find symbol [ERROR] symbol: method assertEquals(java.lang.String,java.lang.String,java.lang.String) [ERROR] location: class org.freedesktop.dbus.test.MarshallingTest [ERROR] /home/larsi/projekte/dbus-java/dbus-java/src/test/java/org/freedesktop/dbus/test/MarshallingTest.java:[103,9] cannot find symbol [ERROR] symbol: method assertEquals(java.lang.String,java.lang.String,java.lang.String) [ERROR] location: class org.freedesktop.dbus.test.MarshallingTest [ERROR] -> [Help 1]` Even when skipping execution of tests, it tries to compile them.

Since commit 2e171f152a3e71810ed06a4f8c58d9b3fad2ad25 MarshallingTest inherits from AbstractBaseTest, which I do not see in the repo.

hypfvieh commented 3 years ago

This is caused by a backport of some tests from the java16 branch. I just pushed the required changes to fix this.

poeschel commented 3 years ago

Thank you! Works as expected!