search

hypfvieh / dbus-java

Improved version of java DBus library provided by freedesktop.org (https://dbus.freedesktop.org/doc/dbus-java/)
https://hypfvieh.github.io/dbus-java/
MIT License
180 stars 72 forks source link

Implement gradle #232

Closed Doomsdayrs closed 1 year ago

Doomsdayrs commented 1 year ago

Using gradle init, then adding patches to correct misbehavior.

hypfvieh commented 1 year ago

Thanks for the PR but I'm sorry I will decline it.

First of all, I'm a Maven guy and I'm happy with the current project setup. I don't see any advantage in using Gradle and also don't miss any feature or option in Maven.

Second: One does not simply upgrade the required Java version when providing a upstream library. Using Java 11 in this project is on purpose. The library is used in many projects and forcing a new Java version may break these. There are still a lot of projects out there using the legacy 3.x version because they only have Java 1.8 (don't ask me why). The plan is to upgrade the minimum Java version to 17 with 5.x major version of dbus-java. There is no fixed release date yet, I assume it might be end of this year or beginning of the next.

Doomsdayrs commented 1 year ago

Thanks for the prompt response! And sorry to hear you aren't willing for this upgrade.

First of all, I'm a Maven guy and I'm happy with the current project setup. I don't see any advantage in using Gradle and also don't miss any feature or option in Maven.

As a developer, when I opened up this java project in InteliJ, the first thing I wondered was "why am I not getting the project auto loaded". Then I realized it was using maven. A quick initialization later, I was able to easily read what the build system was doing and see what dependencies are used where.

Second: One does not simply upgrade the required Java version when providing a upstream library. Using Java 11 in this project is on purpose.

I apologize, I had thought the tool chain used was 17, as one of the modules requires Java 16+. (InteliJ didnt load the project [maven] so it couldn't tell me otherwise). It was only a minor change I did for convenience and I'll change it back in my branch.

hypfvieh commented 1 year ago

As a developer, when I opened up this java project in InteliJ, the first thing I wondered was "why am I not getting the project auto loaded"

That's weird. I usually work with Eclipse but sometimes using IntelliJ for static code analysis and it opens my Maven projects flawlessly and without the need to "port" the project to gradle. I also know several other developers using IntelliJ with Maven as primary build system just fine.

I apologize, I had thought the tool chain used was 17, as one of the modules requires Java 16+. (InteliJ didnt load the project [maven] so it couldn't tell me otherwise). It was only a minor change I did for convenience and I'll change it back in my branch.

Project is Java 11 except the native-transport which requires Java 16 (first release with native support for unix sockets)