search

hypfvieh / dbus-java

Improved version of java DBus library provided by freedesktop.org (https://dbus.freedesktop.org/doc/dbus-java/)
https://hypfvieh.github.io/dbus-java/
MIT License
180 stars 72 forks source link

[Feature request] Any plan in adding a module-info ? #250

Closed sblantipodi closed 6 months ago

sblantipodi commented 6 months ago

Hi, thanks for the super awesome lib and for your work here.

When I try to use jlink on software that uses dbus-java I get this error: [ERROR] The given dependency C:\Users\sblantipodi.m2\repository\com\kohlschutter\junixsocket\junixsocket-core\2.8.3\junixsocket-core-2.8.3.pom does not have a module-info.java file. So it can't be linked.

any plan to add a module-info?

Thanks :)

hypfvieh commented 6 months ago

thanks for the super awesome lib and for your work here.

Thanks a lot.

When I try to use jlink on software that uses dbus-java I get this error: [ERROR] The given dependency C:\Users\sblantipodi.m2\repository\com\kohlschutter\junixsocket\junixsocket-> core\2.8.3\junixsocket-core-2.8.3.pom does not have a module-info.java file. So it can't be linked.

any plan to add a module-info?

I'm afraid that this nothing I can change because the error is related to the 3rd party dependency junixsocket. Dbus-java already provides module-info files. Maybe you ask the junixsocket people to fix this.

If you don't need file descriptor support you may also be able change your dependencies by remove dbus-java-transport-junixsockets and replace it by dbus-java-native-unixsockets (if you use Java 16+) or dbus-java-jnr-unixsockets. The later also has limited support of file descriptors when adding dbus-java-nativefd as additional dependency.

sblantipodi commented 6 months ago

thank you very much for the kind and useful answer, I appreciate it. closing the issue :)