search

hypfvieh / dbus-java

Improved version of java DBus library provided by freedesktop.org (https://dbus.freedesktop.org/doc/dbus-java/)
https://hypfvieh.github.io/dbus-java/
MIT License
185 stars 73 forks source link

Incorrect imports generated by CreateInterface #49

Closed sshort closed 5 years ago

sshort commented 5 years ago

CreateInterface generates code using some hard coded imports that refer to the old package names for some refactored classes, including:

In createException: out.println("import org.freedesktop.dbus.DBusExecutionException;");

In createTuple(): out.println("import org.freedesktop.dbus.Position;");

These should be: out.println("import org.freedesktop.dbus.exceptions.DBusExecutionException;"); out.println("import org.freedesktop.dbus.annotations.Position;");

hypfvieh commented 5 years ago

I merged your PR. Anyway CreateInterface is legacy code and should no longer be used as it will be removed in the future...

sshort commented 5 years ago

What's going to replace it?

hypfvieh commented 5 years ago

see: Issue 35

sshort commented 5 years ago

Ah - sorry - I completely missed that. I'll give it a go.