iTrace-Dev / iTrace-Eclipse

Eclipse plugin to identify textual and interface elements based on iTrace Core gaze data
GNU General Public License v3.0
5 stars 2 forks source link

Extra Eclipse Plugin Controls on Plugin Window #42

Closed dtg3 closed 4 years ago

dtg3 commented 4 years ago

There still appear to be extra controls on the iTrace Eclipse plugin window: controls

At this stage of the game I would simply say hide the controls.

clptrsn commented 4 years ago

Is this off the installer version? I think that code is based off the master version. The development is up to date and gets rid of this button

Should we merge development into master at this point anyway. It might make the installers easier to make

clptrsn commented 4 years ago

The XML export button is in development. I can remove that tonight

dtg3 commented 4 years ago

Yes, I'm testing eclipse from the installation site and the installers should have been based off development. @Zealot-311 can you weigh in on what branch conatins the installer stuff or the branch it is based on?

@clptrsn it will need to be merged eventually, but it would be best if the process was done in development and merged into master (less likely to create a merge conflict depending on what files the installation site process involves).

dtg3 commented 4 years ago

@clptrsn Just pulled and built development (HEAD commit is 00eaa5ca7b9204b10b3a229d92bd337752971220): plugin_controls

XML Export checkbox and file browser button (...) are still present.

clptrsn commented 4 years ago

Removed in 2e6a19a27b8c1ad17814a984b8b36b7e1957fa45

dtg3 commented 4 years ago

I can verify the extra controls are no longer present on the form. Will test tomorrow with trackers to check for regressions.

dtg3 commented 4 years ago

Does not appear to introduce regression.