search

ibnuda / dactyl-keyboard

Web generator for dactyl keyboards.
https://dactyl.siskam.link
GNU Affero General Public License v3.0
199 stars 51 forks source link

Improve hotswap holes #77

Closed Kosaro closed 3 years ago

Kosaro commented 3 years ago

Tested on left and right sides of manuform and lightcycle.

Hotswap now has two holes instead of four: image

I also rotated the keys on the lightcycle and the top of the thumb on the manuform, since they appeared to be facing the wrong way (lmk if this was supposed to be this way, I can remove it from the pull request). It used to be like this: image

ibnuda commented 3 years ago

have you checked the holes of the left hand side? would it be usable?

Kosaro commented 3 years ago

have you checked the holes of the left hand side? would it be usable?

Left: image

Right: image

ibnuda commented 3 years ago

thanks.

yejianfengblue commented 3 years ago

The code

(if is-right?
  plus-hole
  plus-hole-mirrored)
(if is-right?
  minus-hole
  minus-hole-mirrored)

is rollbacked by https://github.com/ibnuda/dactyl-keyboard/commit/a0edea385f76c257d6e7b7e2f4cacfe2c49c6686

Plan to add it back?

Kosaro commented 3 years ago

The code

(if is-right?
  plus-hole
  plus-hole-mirrored)
(if is-right?
  minus-hole
  minus-hole-mirrored)

is rollbacked by https://github.com/ibnuda/dactyl-keyboard/commit/a0edea385f76c257d6e7b7e2f4cacfe2c49c6686

Plan to add it back?

That's strange, was it just that part? I won't be able to in the near future, so if you're able to go ahead.