#1059 📁 Clinical Download Filename Update

icgc-argo / argo-clinical

Clinical data submission for ARGO programs.

GNU Affero General Public License v3.0

2 stars 0 forks source link

#1059 📁 Clinical Download Filename Update #1098

Closed demariadaniel closed 6 months ago

demariadaniel commented 6 months ago

Description of changes

Adds Entity Name to file download when 1 Entity is selected (vs download all entities)
Adjusts Displayed Month Date Value

Type of Change

[x] Bug
[ ] Refactor
[ ] New Feature
[ ] Release Candidate

Checklist before requesting review:

[ ] Check branch (code change PRs go to develop not master)
[ ] Check copyrights for new files
[ ] Manual testing
[ ] Regression tests completed and passing (double check number of tests).
[ ] Spelling has been checked.
[ ] Updated swagger docs accordingly (check it's still valid)
[ ] Set validationDependency in meta tag for Argo Dictionary fields used in code

ciaranschutte commented 6 months ago

just a comment. might be worth using the returned entity names from the query instead of the parsed request entity names. frontend can submit anything and there seems to be minimal error checking on the entity parts of this code (there are thrown errors for invalid programs)

ciaranschutte commented 6 months ago

as we discussed on slack - endpoint is array of strings but our use case is ok for a single name in the filename as we don't download multiple files (eg. a filename with 14 diff entity names)

demariadaniel commented 6 months ago

just a comment. might be worth using the returned entity names from the query instead of the parsed request entity names. frontend can submit anything and there seems to be minimal error checking on the entity parts of this code (there are thrown errors for invalid programs)

Sounds good, insures names are standardized, protects against edge cases: https://github.com/icgc-argo/argo-clinical/pull/1098/commits/3f2caaf06dd5eb977b5ef3f8c38f22e94822fb26