🐛 #1111 Handle Empty ClinicalRegistrationData Records - Githubissues

icgc-argo / argo-clinical

Clinical data submission for ARGO programs.

GNU Affero General Public License v3.0

2 stars 0 forks source link

🐛 #1111 Handle Empty ClinicalRegistrationData Records #1137

Closed demariadaniel closed 7 months ago

demariadaniel commented 7 months ago

Link to Issue

Description

Handles empty values for ClinicalRegistrationData.records with default [] Refactor variable definitions for readability

Checklist

Type of Change

[x] Bug
[x] Refactor
[ ] New Feature
[ ] Release Candidate

Checklist before requesting review:

[ ] Check branch (code change PRs go to develop not master)
[ ] Check copyrights for new files
[ ] Manual testing
[ ] Regression tests completed and passing (double check number of tests).
[ ] Spelling has been checked.
[ ] Updated swagger docs accordingly (check it's still valid)
[ ] Set validationDependency in meta tag for Argo Dictionary fields used in code

ciaranschutte commented 7 months ago

@demariadaniel please let me know which line change is on. prettier has formatted the entire file so I'm not sure where the diff is.

demariadaniel commented 7 months ago

@demariadaniel please let me know which line change is on. prettier has formatted the entire file so I'm not sure where the diff is.

see: https://github.com/icgc-argo/argo-clinical/pull/1137#discussion_r1489988825