🕷️ 1115 fix clinical data resolver completion

icgc-argo / argo-clinical

Clinical data submission for ARGO programs.

GNU Affero General Public License v3.0

2 stars 0 forks source link

🕷️ 1115 fix clinical data resolver completion #1139

Closed demariadaniel closed 4 months ago

demariadaniel commented 4 months ago

Link to Issue

https://app.zenhub.com/workspaces/icgc-argo-platform-dk-production-board-5e542d38415f5034e9fed89d/issues/gh/icgc-argo/roadmap/1115

Description

Fixes several bugs related to ClinicalData resolver:

CompletionState is now populated correctly
Default value for query sort field
Error handling when ClinicalErrors migration schema is not found
API Input filter type updated

Checklist

Type of Change

[x] Bug
[ ] Refactor
[ ] New Feature
[ ] Release Candidate

Checklist before requesting review:

[ ] Check branch (code change PRs go to develop not master)
[ ] Check copyrights for new files
[ ] Manual testing
[ ] Regression tests completed and passing (double check number of tests).
[ ] Spelling has been checked.
[ ] Updated swagger docs accordingly (check it's still valid)
[ ] Set validationDependency in meta tag for Argo Dictionary fields used in code

ciaranschutte commented 4 months ago

Screenshot 2024-02-20 at 11 39 47 AM @demariadaniel missing type update here: src/submission/validation-clinical/therapy.ts and the completion state has a type error also

npm run type-check should get you the same result as above

build won't work without TS checks passing

demariadaniel commented 4 months ago

@demariadaniel missing type update here: src/submission/validation-clinical/therapy.ts and the completion state has a type error also

npm run type-check should get you the same result as above

build won't work without TS checks passing

Sorry, app ran and vscode showed no errors so missed this. The issue w/ Type duplication is because incoming API filters and Mongo filters are different, but very similar Will untangle in this commit

ciaranschutte commented 4 months ago

@demariadaniel missing type update here: src/submission/validation-clinical/therapy.ts and the completion state has a type error also npm run type-check should get you the same result as above build won't work without TS checks passing

Sorry, app ran and vscode showed no errors so missed this. The issue w/ Type duplication is because incoming API filters and Mongo filters are different, but very similar Will untangle in this commit

np. I thought we had github build checks for this repo that should have caught the TS thing, will need to investigate that.

demariadaniel commented 4 months ago

np. I thought we had github build checks for this repo that should have caught the TS thing, will need to investigate that.

@ciaranschutte Updated https://github.com/icgc-argo/argo-clinical/pull/1139/commits/e3587ebd5b024d9ad7f01c61882dc991119b805f