Clinical Errors retrieve Schema from DB

[demariadaniel]

Link to Issue

https://github.com/icgc-argo/argo-clinical/issues/1146

Description

ClinicalErrors / Submitted Data page fail when requested migration dictionary cannot be found

• Updates schemaRepo.get to allow direct request for specific dictionary version

• Refactors getValidRecordsPostSubmission, renamed to filterErrorsWithUpdatesOrExceptions

• If filterErrorsWithUpdatesOrExceptions cannot find the required Dictionary, it makes a request to Lectern and saves the needed Dictionary to the DB

• Fixes matchDonorErrorsWithExceptions bug which created duplicate error records

• Overall code readability improvements

Checklist

Type of Change

• [x] Bug
• [x] Refactor
• [ ] New Feature
• [ ] Release Candidate

Checklist before requesting review:

• [ ] Check branch (code change PRs go to develop not master)
• [ ] Check copyrights for new files
• [ ] Manual testing
• [ ] Regression tests completed and passing (double check number of tests).
• [ ] Spelling has been checked.
• [ ] Updated swagger docs accordingly (check it's still valid)
• [ ] Set validationDependency in meta tag for Argo Dictionary fields used in code

[ciaranschutte]

some of the stringifiedRecords in this codebase is actually stringified and some is not. sometimes a TypedDataRecord is the type other times it's DataRecord

export declare class DataRecord {
    readonly [k: string]: string | string[];
}
export declare class TypedDataRecord {
    readonly [k: string]: SchemaTypes;
}
``` from lectern client schema entities

[demariadaniel]

some of the stringifiedRecords in this codebase is actually stringified and some is not. sometimes a TypedDataRecord is the type other times it's DataRecord

export declare class DataRecord {
    readonly [k: string]: string | string[];
}
export declare class TypedDataRecord {
    readonly [k: string]: SchemaTypes;
}
``` from lectern client schema entities

I will double check this is all being handled properly. This is because revalidating records and checking for exceptions need similar (but not equal) record values and use of any elsewhere is obscuring potential issues