icgc-argo / argo-clinical

Clinical data submission for ARGO programs.
GNU Affero General Public License v3.0
2 stars 0 forks source link

Improve Clinical Error specificity #1165

Open demariadaniel opened 3 months ago

demariadaniel commented 3 months ago

Clinical Errors / Schema Validation Errors should be updated to include an identifying value (for example primary_diagnosis_id) or other detailed information related to the specific record with the error

See attached screenshot where DO251485 has two records, both have lymph_nodes_examined_method marked as an error, but only one of the two records has the value Yes which is triggering the error

This is because the front end does not have enough information to distinguish which record has an error

Screenshot 2024-03-14 at 11.01.35 AM.png

May be able to leverage 'Index' property on Errors on Platform UI to fix this Otherwise, solution will most likely involve changes on both Lectern Client (processRecords) to populate Error Records with additional data, and Argo Clinical (Clinical Errors) to return correct Error Record objects

demariadaniel commented 3 months ago

Related to: https://app.zenhub.com/workspaces/icgc-argo-platform-dk-production-board-5e542d38415f5034e9fed89d/issues/gh/icgc-argo/roadmap/1105

demariadaniel commented 3 months ago

Also: https://app.zenhub.com/workspaces/icgc-argo-platform-dk-production-board-5e542d38415f5034e9fed89d/issues/gh/icgc-argo/platform-ui/2620