↕️ Feat/ #1127 Exception Manifest sorting - Githubissues

icgc-argo / argo-clinical

Clinical data submission for ARGO programs.

GNU Affero General Public License v3.0

2 stars 0 forks source link

↕️ Feat/ #1127 Exception Manifest sorting #1167

Closed demariadaniel closed 3 months ago

demariadaniel commented 3 months ago

Link to Issue

Description

Sorts Entity Property Exceptions by SubmitterId and SubmitterEntityId (if SubmitterId is the same, i.e. multiple records from the same submitter)
Program, Exception Type, Schema are enforced by positional variable declarations / array population
Includes related unit tests

Checklist

Type of Change

[ ] Bug
[ ] Refactor
[x] New Feature
[ ] Release Candidate

Checklist before requesting review:

[ ] Check branch (code change PRs go to develop not master)
[ ] Check copyrights for new files
[ ] Manual testing
[ ] Regression tests completed and passing (double check number of tests).
[ ] Spelling has been checked.
[ ] Updated swagger docs accordingly (check it's still valid)
[ ] Set validationDependency in meta tag for Argo Dictionary fields used in code

ciaranschutte commented 3 months ago

@demariadaniel looks good! please fix https://github.com/icgc-argo/argo-clinical/pull/1167#discussion_r1534637941 and https://github.com/icgc-argo/argo-clinical/pull/1167#discussion_r1534638190

the rest are suggestions