❌ Sort Invalid Clinical Records first - Githubissues

icgc-argo / argo-clinical

Clinical data submission for ARGO programs.

GNU Affero General Public License v3.0

2 stars 0 forks source link

❌ Sort Invalid Clinical Records first #1184

Closed demariadaniel closed 1 month ago

demariadaniel commented 2 months ago

Link to Issue

Description

Sorts Invalid Clinical Records to the top of the list

Donor records already include sorting rules for isValid; this change impacts Clinical Entity records

Relates to UI changes in: https://github.com/icgc-argo/platform-ui/pull/2763

Testing examples are in ticket comments

Updates Lectern Client to 1.5 so that all errors have populated values; allows accurate sorting into invalid/valid entity record groups

Screenshot 2024-05-16 at 3 08 02 PM

Checklist

Type of Change

[x] Bug
[ ] Refactor
[ ] New Feature
[ ] Release Candidate

Checklist before requesting review:

[ ] Check branch (code change PRs go to develop not master)
[ ] Check copyrights for new files
[ ] Manual testing
[ ] Regression tests completed and passing (double check number of tests).
[ ] Spelling has been checked.
[ ] Updated swagger docs accordingly (check it's still valid)
[ ] Set validationDependency in meta tag for Argo Dictionary fields used in code