icgc-argo / argo-clinical

Clinical data submission for ARGO programs.
GNU Affero General Public License v3.0
2 stars 0 forks source link

Submitted Ids should not be case sensitive #139

Open rosibaj opened 5 years ago

rosibaj commented 5 years ago

Actual Behaviour

Searching for a donor_id or specimen_id or sample_id is case sensitive.

Steps to Reproduce

  1. Search for a donor id with https://clinical.qa.argo.cancercollaboratory.org/clinical/specimens/id?programId=PACA-AU&submitterId=RBSP1
  2. see that it returns not found
  3. Search for a donor id with https://clinical.qa.argo.cancercollaboratory.org/clinical/specimens/id?programId=PACA-AU&submitterId=rbsp1
  4. see that it returns SP40

Expected Behaviour

rosibaj commented 4 years ago

Discussion in grooming

blabadi commented 4 years ago

the title & description and the last comment in this issue seem out of sync to me

rosibaj commented 4 years ago

@blabadi the original title was submitted as a bug - After discussion we agreed that:

The documentation for this has not yet been completed, so i have left this ticket to make sure that the concepts get addressed when needed!

rosibaj commented 4 years ago

https://www.hl7.org/fhir/datatypes.html

This decision was based on the Hl7/FIRE id spec here