Remove cross file validation for tumour_designation_status--> specimen fields that are being removed.

icgc-argo / argo-clinical

Clinical data submission for ARGO programs.

GNU Affero General Public License v3.0

2 stars 0 forks source link

Closed rosibaj closed 3 years ago

rosibaj commented 3 years ago

We will be removing 4 fields as "required" from the tumour calculations in https://github.com/icgc-argo/argo-dictionary/issues/214
Currently, clinical has a calculation to ensure that "required" tumour fields are submitted for tumour-type (#408)

We need to edit the logic such that:

Are not required to be submitted when a specimen file is submitted.

rosibaj commented 3 years ago

Tested on QA

was able to upload a file with the 4 specified fields missing. When validation was clicked, it passed validation.
was able to upload a file with the 4 specified fields missing as well as percent_tumour_cells. When validaiton was clicked, it correctly highlighted that percent_tumour_cells is required for type Tumour!