search

icgc-argo / argo-clinical

Clinical data submission for ARGO programs.
GNU Affero General Public License v3.0
2 stars 0 forks source link

Feature Request: Allow Dictionary Migration of `integer` to `number` #644

Closed rosibaj closed 3 years ago

rosibaj commented 3 years ago

Detailed Description

A dictionary change is rejected as a breaking change if a a field type is changed from integer to number

Example: Migrate: to dictionary version 80.5 in the ARGO QA Environment: 

    {
        "_id": "604bf2c33811dc001ea01bb1",
        "name": "ICGC-ARGO Data Dictionary",
        "version": "80.5"
    },

There is a migration manager in the code that handles these rules that can be edited.

Expected Behaviour

This should be allowed as all numbers are integers, thus no data would be broke. It is making a field more permissive, not less permissive.

rosibaj commented 3 years ago

tested with several dictionary migrations in the sprint including int --> number

blabadi commented 3 years ago

deployed to staging

rosibaj commented 3 years ago

Confirmed on Ulyssus Release May 10, 2021

rosibaj commented 3 years ago

Confirmed on Ulyssus Release May 10, 2021