search

ida-arbeitszeit / arbeitszeitapp

A webapp for labour-time calculation.
https://arbeitszeitapp.readthedocs.io
GNU Affero General Public License v3.0
33 stars 4 forks source link

Refactor show r account details tests #1007

Closed sloschert closed 2 months ago

sloschert commented 3 months ago

Refactor and expand show r account use case tests.

Plan: b05bef9c-4dbf-4cd1-9e99-59219dfa9c4b (1x)

seppeljordan commented 2 months ago

While I find the blue info box useful I would like to question the usefulness of the two newly added data to the account overview. I would not now I which situation I would be interested in those numbers. I wouldn't be so critical on those numbers if I wouldn't suspect performance degradation from this PR>

seppeljordan commented 2 months ago

Okay, after some testing I found that this change might actually improve performance. My question still stands though. In which situation would those numbers be useful?

sloschert commented 2 months ago

The purpose is demystification of the balance number, as described here for account P: https://github.com/arbeitszeit/arbeitszeitapp/pull/982#issue-2216872992

also, as discussed in a weekly meeting, the idea is to get rid of some of the cryptic metrics on the Company summary page.

sloschert commented 2 months ago

As discussed in our meeting, I retrieve the changes proposed to the R account details. I only left the refactoring and expansion of the use case tests. Clarifying help texts should be added in future PRs to the account pages.