search

ida-arbeitszeit / arbeitszeitapp

A webapp for labour-time calculation.
https://arbeitszeitapp.readthedocs.io
GNU Affero General Public License v3.0
36 stars 4 forks source link

Create ListRegisteredHoursWorkedUseCase #1034

Closed sloschert closed 3 months ago

sloschert commented 3 months ago

The request object for this use case takes a company_id. We expect this company to exist in the database.

Pull Requests targeting web and flask layer will follow.

See issue #1029 for motivation.

Plan: 371825c0-3112-47cd-9cb0-fea799fad3ee (2x)

sloschert commented 3 months ago
  • Why not define ascending/descending in list_registered_hours_worked via a Request option with descending as a default?
  • Maybe adding transaction.id to RegisteredHoursWorked could make sense?
  • What about limit and offset for listings?
  • What about a date range for listings?
  • What about listings for a specific worker?

Thanks for these ideas, @4lm, they all make sense. Nevertheless, my target is to firstly create a bare bones listing. At least until now I tried in general not to create properties of the Use Case Request and Response objects if I do not plan to use them in the www layer (controller and presenter). And I do not yet plan to implement pagination, custom ordering, date range or filtering for specific worker (we can discuss, though, if we should do this already). The transaction.id is neither needed as far as I can see (the worker_id instead is definitely needed to identify the worker).

sloschert commented 3 months ago

@seppeljordan I register 2x consumption