search

iddohau / rust-strings

Extracting strings from binary data
MIT License
6 stars 1 forks source link

Allow comilation using pip wheel #44

Closed Krakoer closed 1 year ago

Krakoer commented 1 year ago

Hi,

Adding a [tool.maturin] section in the pyproject.toml with 

profile = "release"
features = ["python_bindings"]

would allow for custom build using the pip wheel command.

Context: My project's CI builds the dependencies using the pip wheel command on an alpine container, and without this [tool.maturin] section the project builds without the python bindings.

Thank for your work!

iddohau commented 1 year ago

Hi, This sounds like a good idea. Do you want to open a pull request with the change?

iddohau commented 1 year ago

Closing this issue as the pull request with the desired changed has been merge. Thank you for your contribution 😀 https://github.com/iddohau/rust-strings/pull/45