igmhub / cup1d

Cosmology using P1D - small scale clustering of the Lyman alpha forest
2 stars 1 forks source link

add_linP_params module in notebooks #27

Closed armengau closed 1 year ago

armengau commented 1 year ago

The module cup1d.planck.add_linP_params is not in this public version,

andreufont commented 1 year ago

Could you check out the new branch fix_add_linP? I forgot to update that module, since we only used it in old notebooks. https://github.com/igmhub/cup1d/tree/fix_add_linP

I checked that I was able to call that function, but not in the context of the notebooks (I don't have the original Planck chains anymore...)

andreufont commented 1 year ago

I also updated the notebook add_linP_chains, let me know if you can run it successfully and I will merge that branch and close the issue.

armengau commented 1 year ago

Yes, I checked the notebook add_linP_chains works now.

andreufont commented 1 year ago

solved in PR #28