search

igmhub / cup1d

Cosmology using P1D - small scale clustering of the Lyman alpha forest
2 stars 1 forks source link

Ohio QMLE interface updates #47

Closed p-slash closed 10 months ago

p-slash commented 10 months ago

I changed the interface to remove hard-coded numbers. You can pass a filename to read any QMLE output file. I fixed poly_p1d imports. They are in lace.utils not lace.emulator, but please check this one.

jchavesmontero commented 10 months ago

Hi @p-slash! I went through the files and everything checks out, I will test it soon. However, before that, is it possible to read the table using numpy instead of panda? It is fine if not, but I prefer using as few external packages as possible.

p-slash commented 10 months ago

Unfortunately, numpy doesn't have a suitable function. I use astropy.ascii to read these files actually, but astropy wasn't part of cup1d or lace, so I didn't want to add that. pandas is a requirement though, so it already comes with lace I think.

jchavesmontero commented 10 months ago

Sorry, I thought it was not a requirement because I have not used it so far. It is perfect then.

andreufont commented 10 months ago

Thanks for taking care of this. Could you confirm that we can now read the QMLE EDR results, and if so, could you add a notebook or script showing how to read it and make a plot?

andreufont commented 10 months ago

By looking at the commits it doesn't look like this is the case, so I'll open an Issue