search

igmhub / cup1d

Cosmology using P1D - small scale clustering of the Lyman alpha forest
2 stars 1 forks source link

nyx IGM history #49

Closed jchavesmontero closed 9 months ago

andreufont commented 10 months ago

This should address Issue #41 when ready

jchavesmontero commented 9 months ago

@andreufont The PR is huge, but you will notice that most changes have to do with reformatting the files to agree with PEP9. Let me know if you need any help with the review. Let's try to merge more often in the near future. I think it would be best if we do the merge after Naim finishes his PR.

andreufont commented 9 months ago

Yes, it is a bit annoying to review with the formatting changes. Could you point me to the relevant changes in code?

jchavesmontero commented 9 months ago

@andreufont I pointed you to all relevant changes in .py files. There are also some new .py files that you may want to review. Some ipynb files also changed, but I would focus on these later as most will need to be updated. I noticed that there was a small inconsistency in likelihood.py that I will fix in a commit.

jchavesmontero commented 9 months ago

@andreufont I finished adding comments, feel free to review