DESI added & Highres P1d data fixed

[p-slash]

I updated the data with the actual measurements for Karacayli 2022 high resolution. Covariance can be implemented later if needed. Please replot P1D figures and confirm that Fig 7 of the paper can be reproduced.

[p-slash]

I also implemented DESI EDR QMLE results here. High k values that are excluded in z bin have large covariance. This uses full covariance by default. Covariance between redshift bins are still ignored

[jchavesmontero]

I updated the data with the actual measurements for Karacayli 2022 high resolution. Covariance can be implemented later if needed. Please replot P1D figures and confirm that Fig 7 of the paper can be reproduced.

I guess you mean Fig. 8 of https://ui.adsabs.harvard.edu/abs/2023arXiv230606316K/abstract, right?

[jchavesmontero]

I was trying to reproduce Fig. 8 but I cannot find the measurements at z=2

data_Karacayli2023.P1D_Karacayli2023().z
array([2.2, 2.4, 2.6, 2.8, 3. , 3.2, 3.4, 3.6, 3.8])

[jchavesmontero]

@p-slash , I tried to reproduce your Fig. 8 at the end of p1d_measurements/compare_p1d_data.ipynb. Could you check what is happening with z=2 data? Once this is fixed I am happy with the merge

[p-slash]

I changed to DESI p1d interface to remove kmax < knyq / 2 as well. I do not recommend using z=2.0 bin of DESI EDR and keeping k values to less than half the Nyquist frequency. These can be changed by using the arguments when creating class instances.

[jchavesmontero]

@andreufont should I merge?

[andreufont]

Sure, if you have reviewed and it works go ahead!