search

igniteram / protractor-cucumber-typescript

e2e kickstarter test framework which consists of protractor, cucumber frameworks using typescript lang!
MIT License
196 stars 170 forks source link

Hooks - After not getting executed with cucumber upgrade #41

Closed PingleSneha closed 6 years ago

PingleSneha commented 6 years ago

Hi. Can you please upgrade all the dev dependencies specifically cucumber and reformat the code base. I downloaded ur repo and did some enhancements to suit latest versions of dependencies and also upgraded it to work with geckodriver. Struggling to use after hook with cucumber 3.5 version.

igniteram commented 6 years ago

@PingleSneha

I saw the new features of cucumber version 3.05, there are not much changes done to hooks, only pickle property has been added as an extra argument to before/after hooks. can you try running the hooks again and let me know what error you are facing?

PingleSneha commented 6 years ago

I am not getting any error but code in after Hooks is not getting called. I have simply put in console.log to check if it is getting called and executed.

PingleSneha commented 6 years ago

Hi @igniteram,

The code for hooks works perfectly fine with latest version of protractor as well. There was a silly mistake i did, i had removed hooks.js from cucumber opts, hence it was not working.