igorciz777 / RBC1GP-Translation-Pipeline

A set of tools and instructions to allow easy work on translating the game
GNU General Public License v3.0
18 stars 0 forks source link

Expanding BBS content destroys the file and crashes the game #3

Closed igorciz777 closed 2 months ago

igorciz777 commented 3 months ago

Describe the bug Due to BBS thread titles being stored at the bottom of the file with their own offsets for whatever reason, when expanded those offsets get either overwritten or misplaced, instantly crashing the game

Expected behavior Allow text of any size to be replaced in 231.bin file

Device Both emulation and hardware

Additional context Needs executable patching

igorciz777 commented 3 months ago

Turns out its fixable by moving most of the text data to the bottom of the file with the #JMP command for Atlas

This makes the file size quite bigger than original, might cause issues in the future like a possible size limit - this could be fixed by making all the repeated text (and there is a ridiculous amount) point to one instance

will keep the issue as open for the time being

igorciz777 commented 2 months ago

with gut archive tools v0.4.3 the game now loads the file without issue even when its expanded to >320kb, there should be no issue in translating all the text now