iho-ohi / S-100-Validation-Checks

S-100 Github repository for Validation Check development.
15 stars 1 forks source link

10a check needed to cover RCID is out of range #47

Open LizHahessy opened 4 months ago

LizHahessy commented 4 months ago

We (Klas - S-101 PT test datasets) have received feedback on an S-164 dataset that indicates the need for some validation enhancements. The problem is that in some datasets is that the RCID is out of range. In S-58, this is validated by check 5, which is very explicit: image

S-101 Annex C Part 1 indicates that S-58 check 5 has been replaced by S100_Dev0047.

image

I looked at the Github table of S-100 validation checks and found that the ID S100_Dev0047 was used for another check. Perhaps the one above was not considered relevant as it was greyed out? Anyway, I think that the feedback proves that a check for this is needed. As the range of RCID is defined in S-100 Part 10a-4.4, I think this should be a generic S-100 check.

LizHahessy commented 4 months ago

Need to review and see if can be covered by amending an existing check or by creating a new check