iho-ohi / S-100-Validation-Checks

S-100 Github repository for Validation Check development.
15 stars 1 forks source link

Subsumed Part 17 checks #9

Open rmalyankar opened 1 year ago

rmalyankar commented 1 year ago

Some Part 17 checks are implicitly included in S100_20 and need not be listed as separate checks, because ordinary XML schema-validation using the S-100 generic schemas would detect breaches of the respective check conditions as originally stated.

S100_020 XML catalogues conform to the S-100 Metadata Profile Schemes

Checks subsumed in S100_020 are:

S100_021 S-100 Exchange set contains a conforming S-100_ExchangeCatalogue S100_033 "All resources within an S-100 Exchange Set must be digitally signed and their signatures included in the Exchange Set Catalogue. Or The S-100_DatasetDiscoveryMetadata attribute digitalSignatureValue is mandatory" S100_052 The S100_Datacoverage attribute boundingPolygon instance is mandatory and there can only one instance S100_053 Only one defaultLocale is permitted within S100_Exchange Catalogue S100_055 If userDefinedMaintenanceFrequency is populated the lexical represtantion for duration is the ISO 8601 extended format PnYnMnDTnHnMnS

Recommendations:

  1. Replace S100_033 with "The digital signature is valid"
  2. Replace S100_052 with "The bounding polygon conforms to the Level 3a rules in Part 7".
  3. Add a rule about whether data coverage polygons can have holes ( TBD whether the answer should be yes or no).
  4. Replace S100_053 with "The language in defaultLocale and otherLocale must be one of the languages listed in the S-100 codelists catalogue. (This file is part of the S-100 generic schemas distribution.)"
  5. Add a check for repeated locales: Language/country combinations in a defaultLocale or otherLocale entry must not be repeated in an otherLocale attribute within the S100_ExchangeCatalogue element's attributes, or within the same discovery metadata block for any resource.
MikusRL commented 1 year ago

..., or within the same discovery metadata block for any resource.

@rmalyankar do you mean by this anywhere in the metadata within a single exchange set across all datasets? Thanks.

rmalyankar commented 1 year ago

..., or within the same discovery metadata block for any resource.

@rmalyankar do you mean by this anywhere in the metadata within a single exchange set across all datasets? Thanks.

Each instance of S100_DatasetDiscoveryMetadata or S100_CatalogueDiscoveryMetadata, noting that otherLocale is present only in those classes and S100_ExchangeCatalogue.

LizHahessy commented 11 months ago

Decisions at VTC 3 04/09/23 Items 1 ,2 & 4 Updated Check S100_033 (S100_Dev0312), S100_0052 (S100_Dev0331) and S100_053 (S100_Dev0332) with revised wording. Item 3 - will wait for decision at S100 WG8 Item 5 - Need link to S100 for check reference

LizHahessy commented 5 months ago

Discussed at VTC 8 Item 3 - need to check to see if this was discussed at S-100 WG8 Item 5 - Liz to add check and to find a Clause in S-100 to link it to (S100_Dev0348)

rmalyankar commented 1 week ago

Dev0348 is a different test in 0.1.0 list (an ISO 8211 format check). The others cited in the post-VTC3 comment are accounted for:

Items 1 ,2 & 4 Updated Check S100_033 (S100_Dev0312), S100_0052 (S100_Dev0331) and S100_053 (S100_Dev0332) with revised wording.

Items 3 and 5 appear to be still open(?)