ihsoft / KIS

Kerbal Inventory System
Other
110 stars 51 forks source link

Revert version file's VERSION.BUILD to match current release #385

Closed HebaruSan closed 3 years ago

HebaruSan commented 3 years ago

4773123873b44d21ae1fa62aa3530c3453d3c6be changed VERSION.BUILD in the remote version file, which tells KSP-AVC and CKAN that it is for a different version than the download, which prevents the other changes in that commit from applying and keeps KIS 1.28 stuck as compatible with KSP 1.8.

Recommend changing the BUILD property back so it matches and the intended compatibility can be applied. If you have some kind of automated build script populating this, probably a good idea to remove that as well.

Tagging @ihsoft to ensure GitHub sends a notification.

ihsoft commented 3 years ago

Wow! Didn't realize it can affect CKAN. Thanks.

HebaruSan commented 3 years ago

Thanks for the merge! That should help folks who are getting confused about the compatibility (sometime within the next 30 minutes).

Sinomen commented 3 years ago

Would you mind to change the compatibility information for 1.27 too to KSP 1.11. please?

Thanks in advance :)

HebaruSan commented 3 years ago

@Sinomen That kind of maintenance the CKAN team can do ourselves (I know it's confusing; to sum up, the current release has special automatic treatment and the older releases are maintained manually). If you are interested in trying that, you can edit the files here and submit pull requests:

Sinomen commented 3 years ago

Never did a pull request, uh... and I don't want to botch up things. So what would I do then exactly?

HebaruSan commented 3 years ago

It's pretty quick once you get used to it:

  1. Click the file name to view it
  2. Click the pencil icon towards the upper right to edit it
  3. Make your changes
  4. At the bottom there is a box for typing a short description
  5. Keep clicking the green buttons until you end up making a pull request

Let's continue this back at KSP-CKAN/NetKAN#8291 so we aren't spamming email notifications over here...