Add air conditioner support

iklein99 / homebridge-smartthings

This is a plugin to Homebridge to connect your Smartthings network into Apple Home Kit.

Apache License 2.0

150 stars 52 forks source link

Add air conditioner support #167

Closed lucaponzanelli closed 11 months ago

lucaponzanelli commented 1 year ago

Hi, I've implemented air conditioner support for your plugin as I had the same need as Issue #88. I had to change the way capabilities are assigned to services to make this work. I hope I did not over refactored, and that it might work for you!

This PR does the following:

add AirConditionerService as BaseService
expose mandatory thermostat and fan from AirConditionerService
expose optional HumiditySensor from AirConditionerService
add configuration option (ExposeHumiditySensorForAirConditioners) to make HumiditySensor exposure optional
refactor service/capability assignment to avoid duplicated sensors

moexpa commented 11 months ago

I have a simple question: how can I use your branch with air conditioning support? That's the only functionality I require from the plugin.

iklein99 commented 11 months ago

I’m starting to review the changes. I plan to test this out in the next week or two. Stay tuned.

On Jul 19, 2023, at 1:10 AM, moexpa @.***> wrote:

I have a simple question: how can I use your branch with air conditioning support? That's the only functionality I require from the plugin.

— Reply to this email directly, view it on GitHub https://github.com/iklein99/homebridge-smartthings/pull/167#issuecomment-1641419076, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABG55EWSCEYTTYCCJKDZ5N3XQ5T3FANCNFSM6AAAAAAW2UJKDI. You are receiving this because you are subscribed to this thread.