search

iklein99 / homebridge-smartthings

This is a plugin to Homebridge to connect your Smartthings network into Apple Home Kit.
Apache License 2.0
158 stars 53 forks source link

Water Leak Sensors coming through as Temp Sensors #52

Closed sebastiangoldstein closed 1 year ago

sebastiangoldstein commented 1 year ago

Is your feature request related to a problem? Please describe: I have three of the Samsung GP-U999SJVLCAA SmartThings Water Leak Sensors Amazon Link: https://www.amazon.com/Samsung-GP-U999SJVLCAA-Smart-things-Sensor/dp/B07F951JDP

They are currently coming into Homebridge through the iklein99 Plugin as Temp Sensors and not as leak sensors.

Describe the solution you'd like: Can you add support for leak sensors? In the native SmartThings App, they show Water Sensor - Wet/Dry, Temp, and the Battery level

In HomeBridge / HomeKIt they are only showing Temp and Battery Level and they are not recognized as Leak Sensors.

coryabooth commented 1 year ago

Most sensor have Temperature in addition to leak sensor - is your sensor simply reporting the temperature along with leak?

iklein99 commented 1 year ago

I will very shortly release support for leak sensors.

On Oct 24, 2022, at 11:22 AM, sebastiangoldstein @.***> wrote:

Is your feature request related to a problem? Please describe: I have three of the Samsung GP-U999SJVLCAA SmartThings Water Leak Sensors Amazon Link: https://www.amazon.com/Samsung-GP-U999SJVLCAA-Smart-things-Sensor/dp/B07F951JDP https://www.amazon.com/Samsung-GP-U999SJVLCAA-Smart-things-Sensor/dp/B07F951JDP They are currently coming into Homebridge through the iklein99 Plugin as Temp Sensors and not as leak sensors.

Describe the solution you'd like: Can you add support for leak sensors? In the native SmartThings App, they show Water Sensor - Wet/Dry, Temp, and the Battery level

In HomeBridge / HomeKIt they are only showing Temp and Battery Level and they are not recognized as Leak Sensors.

— Reply to this email directly, view it on GitHub https://github.com/iklein99/homebridge-smartthings/issues/52, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABG55EU4FCUTZBD4EZU3O7TWE2STHANCNFSM6AAAAAARNC2JOY. You are receiving this because you are subscribed to this thread.

iklein99 commented 1 year ago

leak sensor implemented in 1.4.8. Please test and let me know.

veonua commented 1 year ago

[27/10/2022, 16:50:15] [Smartthings] Aqara Leak Sensor returned bad value for status [27/10/2022, 16:50:15] [Smartthings] Bad status from Aqara Leak Sensor [27/10/2022, 16:50:35] [Smartthings] Aqara Leak Sensor returned bad value for status [27/10/2022, 16:50:35] [Smartthings] Bad status from Aqara Leak Sensor [27/10/2022, 16:50:35] [Smartthings] Poll failure on Aqara Leak Sensor

iklein99 commented 1 year ago

THis indicates that your sensor isn't responding with a valid response (probably null). Look in the Smartthings app and see what it is showing for the water sensor value.

You can also put homebridge in debug mode, restart it, and look for the return payload from that sensor and we can see exactly what it is reporting back to the plugin.

veonua commented 1 year ago

[27/10/2022, 16:57:56] [Smartthings] State for Aqara Leak Sensor: 0 [27/10/2022, 16:57:56] [Smartthings] State for Aqara Leak Sensor: 0 [27/10/2022, 16:57:56] [Smartthings] Aqara Leak Sensor battery level normal [27/10/2022, 16:57:56] [Smartthings] Aqara Leak Sensor battery level normal [27/10/2022, 16:57:56] [Smartthings] Battery value from Aqara Leak Sensor: 100 [27/10/2022, 16:57:56] [Smartthings] Battery value from Aqara Leak Sensor: 100 [27/10/2022, 16:57:56] [Smartthings] Aqara Leak Sensor returned bad value for status [27/10/2022, 16:57:56] [Smartthings] Aqara Leak Sensor returned bad value for status [27/10/2022, 16:57:56] [Smartthings] Bad status from Aqara Leak Sensor [27/10/2022, 16:57:56] [Smartthings] Bad status from Aqara Leak Sensor

I don't know why it reports twice

veonua commented 1 year ago

[27/10/2022, 16:59:20] [Smartthings] Updated status for Aqara Leak Sensor: {"voltageMeasurement":{"voltage":{"value":3.015,"unit":"V","timestamp":"2022-05-02T13:50:35.402Z"}},"temperatureAlarm":{"temperatureAlarm":{"value":"cleared","timestamp":"2021-09-28T19:33:11.411Z"}},"waterSensor":{"water":{"value":"dry","timestamp":"2022-10-16T14:50:15.862Z"}},"temperatureMeasurement":{"temperature":{"value":null}},"refresh":{},"battery":{"battery":{"value":100,"unit":"%","timestamp":"2021-12-14T10:14:04.249Z"}}} [27/10/2022, 16:59:20] [Smartthings] Updated status for Aqara Leak Sensor: {"voltageMeasurement":{"voltage":{"value":3.015,"unit":"V","timestamp":"2022-05-02T13:50:35.402Z"}},"temperatureAlarm":{"temperatureAlarm":{"value":"cleared","timestamp":"2021-09-28T19:33:11.411Z"}},"waterSensor":{"water":{"value":"dry","timestamp":"2022-10-16T14:50:15.862Z"}},"temperatureMeasurement":{"temperature":{"value":null}},"refresh":{},"battery":{"battery":{"value":100,"unit":"%","timestamp":"2021-12-14T10:14:04.249Z"}}}

iklein99 commented 1 year ago

The issue is the temperature value is null. Your sensor reports that it supports temperatureMeasurement, but it isn’t returning a valid value. This is working as intended. The other values are reported and usable in Home Kit.

On Oct 27, 2022, at 10:59 AM, Andrew Me @.***> wrote:

[27/10/2022, 16:59:20] [Smartthings] Updated status for Aqara Leak Sensor: {"voltageMeasurement":{"voltage":{"value":3.015,"unit":"V","timestamp":"2022-05-02T13:50:35.402Z"}},"temperatureAlarm":{"temperatureAlarm":{"value":"cleared","timestamp":"2021-09-28T19:33:11.411Z"}},"waterSensor":{"water":{"value":"dry","timestamp":"2022-10-16T14:50:15.862Z"}},"temperatureMeasurement":{"temperature":{"value":null}},"refresh":{},"battery":{"battery":{"value":100,"unit":"%","timestamp":"2021-12-14T10:14:04.249Z"}}} [27/10/2022, 16:59:20] [Smartthings] Updated status for Aqara Leak Sensor: {"voltageMeasurement":{"voltage":{"value":3.015,"unit":"V","timestamp":"2022-05-02T13:50:35.402Z"}},"temperatureAlarm":{"temperatureAlarm":{"value":"cleared","timestamp":"2021-09-28T19:33:11.411Z"}},"waterSensor":{"water":{"value":"dry","timestamp":"2022-10-16T14:50:15.862Z"}},"temperatureMeasurement":{"temperature":{"value":null}},"refresh":{},"battery":{"battery":{"value":100,"unit":"%","timestamp":"2021-12-14T10:14:04.249Z"}}}

— Reply to this email directly, view it on GitHub https://github.com/iklein99/homebridge-smartthings/issues/52#issuecomment-1293655382, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABG55EWQSMHJXSSLX5MCP4LWFKKGNANCNFSM6AAAAAARNC2JOY. You are receiving this because you commented.