Changing colour on a lightbulb doesn't work

[obrassard]

Describe The Bug:

When trying to change the colour of a RGB lightbulb the Home app, an error is thrown by the plugin. It seem that there is an issue with the API call that is made to Smart Things API when trying to set a new hue or saturation.

To Reproduce:

1. Pair a RGB Light Bulb with Samsung SmartThings app
   • in my case it is a Teckin LightBulb paired with SmartLife (Tuya) and connected to SmartThings
2. When the device appear in the Home app, click on the RGB light and try changing the colour
3. The colour of the light bulb does not change an error is printed in the Homebridge Console

Note : Changing the colour in the SmartThings app works properly.

Expected behavior:

The colour of the lightbulb should be updated properly like it is when changing the colour directly in SmartThings

Logs:

Plugin Config:

{
    "bridge": { ...
    },
    "accessories": [],
    "platforms": [
        {
            "name": "Smartthings Plug (IK)",
            "BaseURL": "https://api.smartthings.com/v1/",
            "AccessToken": "...",
            "GarageDoorMaxPoll": 0,
            "PollLocksSeconds": 0,
            "PollDoorsSeconds": 0,
            "PollSensorsSeconds": 5,
            "PollSwitchesAndLightsSeconds": 1,
            "IgnoreDevices": [
                "Piscine"
            ],
            "platform": "HomeBridgeSmartThings"
        }
    ]
}

Environment:

• Plugin Version: v1.4.15
• Homebridge Version: 1.6.0
• Node.js Version: v18.12.1
• NPM Version: 8.19.2
• Operating System: Docker on RaspberryPI OS

[obrassard]

It seems to be an issue with the SmartThings API. Indeed, the API returns a cast error when trying to set hue or saturation with the following body :

[{"capability":"colorControl","command":"setHue","arguments":[10]}]

The request body seems ok according to SmartThings docs but still, we receive an error

However, when changing the color using the setColor command it work...

[iklein99]

Thanks for looking into this. I am currently at the AWS conference. I'll be delayed in trying to fix this.

[obrassard]

Now worry, I started a thread on SmartThings Developers Community to see if they can do something on their side

https://community.smartthings.com/t/bug-with-sethue-and-setsaturation-commands-for-devices-with-colorcontrol-capabilities/253078

[iklein99]

I'm going to fix this by using the setColor command if I detect an error sending individual hue and saturation. Will need you to test for me.

[obrassard]

@iklein99 Perfect, I think that's the best solution considering the information we have. I'm curious to see your PR, as I had tried to do this fix the other day, but wasn't sure how to proceed!

[iklein99]

Fixed in 1.4.17. Try it out and let me know.

[obrassard]

@iklein99 Unfortunately it does not work

The light bulb colour does not change

[iklein99]

Ok. Think I found the issue. Try 1.4.18.

[obrassard]

@iklein99 It works ! Although, it seems that some colors are weird (between what I choose in the Home app, and the color that is really on the bulb), but it is probably not related to your fix

[obrassard]

it seems that some colors are weird

Especially when switching quickly between colours... but anyway it's not a big deal!