search

iklein99 / homebridge-smartthings

This is a plugin to Homebridge to connect your Smartthings network into Apple Home Kit.
Apache License 2.0
150 stars 52 forks source link

Add services #99

Closed veonua closed 1 year ago

iklein99 commented 1 year ago

Andrew,

You are changing the name of the package, etc, so I am not going to just pull this change. What are you expecting me to do with this?

On Dec 5, 2022, at 3:58 PM, Andrew Me @.***> wrote:

You can view, comment on, or merge this pull request online at:

https://github.com/iklein99/homebridge-smartthings/pull/99

Commit Summary

7d36f28 https://github.com/iklein99/homebridge-smartthings/pull/99/commits/7d36f287a9dfc103afc0862f48f4f2562dd1bb22 Merge pull request #1 from iklein99/master 3e17178 https://github.com/iklein99/homebridge-smartthings/pull/99/commits/3e171780f0e1518cd14812574197279da6a5d335 save e7d7999 https://github.com/iklein99/homebridge-smartthings/pull/99/commits/e7d7999a41a56600cc4b086f26add5d98062aecb fix getTargetHeatingCoolingState 9f5d9d1 https://github.com/iklein99/homebridge-smartthings/pull/99/commits/9f5d9d1b346530f4edb993539c5b0d9ab9e0d41d new swerives a956373 https://github.com/iklein99/homebridge-smartthings/pull/99/commits/a9563731db72d7fe3d43a301ad0469bceac41c27 minor 5042ea9 https://github.com/iklein99/homebridge-smartthings/pull/99/commits/5042ea9325a125af84c113e629206d3242a41137 cleanup 3db5918 https://github.com/iklein99/homebridge-smartthings/pull/99/commits/3db5918c2df313528a7d62ea7b7d9fbfbc37210e tidy up File Changes (11 files https://github.com/iklein99/homebridge-smartthings/pull/99/files) M config.schema.json https://github.com/iklein99/homebridge-smartthings/pull/99/files#diff-be1695b1e63a508d59982601f9e1fb7f58247deecb1e427adb77bcad758ae5e5 (4) M package.json https://github.com/iklein99/homebridge-smartthings/pull/99/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519 (14) M src/multiServiceAccessory.ts https://github.com/iklein99/homebridge-smartthings/pull/99/files#diff-289b43cbac746b3adc7e11292f87de9966369bb24b13d834538f4fbbf25619fe (8) M src/platform.ts https://github.com/iklein99/homebridge-smartthings/pull/99/files#diff-8260ea6250f2a0f124153ffb1bddae058191ea4e8baf1de5d4746083f6c44d81 (2) A src/services/airQualityService.ts https://github.com/iklein99/homebridge-smartthings/pull/99/files#diff-74e1d4e4861ff8d1fed696833450c3f89e7b055d3b324e38b135e3308b2d7669 (55) A src/services/dustSensorService.ts https://github.com/iklein99/homebridge-smartthings/pull/99/files#diff-f4ad5a0fd6886fa7d5b0620d6e2f1c838dd91db56565d19f72c701fe009ffc6f (24) R src/services/fanSpeedService.ts https://github.com/iklein99/homebridge-smartthings/pull/99/files#diff-bed23ce0f1577f1ba3b2c23fda91899cf54412eecbb16c54312efa5c4c8daf07 (0) M src/services/lightService.ts https://github.com/iklein99/homebridge-smartthings/pull/99/files#diff-98a56d5b2e32af43504c797aa5f2607b48f7954e01f7e65080a6b0f3066fcc7b (35) A src/services/thermostatService.ts https://github.com/iklein99/homebridge-smartthings/pull/99/files#diff-666747a07e8486f5d54e4c4076b098429df583d966d5031f719cd4c58a53b3b5 (192) M src/services/windowCoveringService.ts https://github.com/iklein99/homebridge-smartthings/pull/99/files#diff-e2a679bfebd23b4817ac9fdb637e2e5158c323b72ffa24904c9e162538055a33 (2) M src/settings.ts https://github.com/iklein99/homebridge-smartthings/pull/99/files#diff-bb57a3bd912abc3ec2e729cb8a743838487677a5517683d0c8913a3619ac296a (4) Patch Links:

https://github.com/iklein99/homebridge-smartthings/pull/99.patch https://github.com/iklein99/homebridge-smartthings/pull/99.diff — Reply to this email directly, view it on GitHub https://github.com/iklein99/homebridge-smartthings/pull/99, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABG55ETLN2V4WWBX2M455S3WLZJP3ANCNFSM6AAAAAASUW7M7I. You are receiving this because you are subscribed to this thread.

veonua commented 1 year ago

Sorry Ira,

wrong destination, meant to merge to my own repo for testing. please remove

iklein99 commented 1 year ago

No worries. I may want to pull in some of your changes into my master. Are you up to date on my master branch?

On Dec 5, 2022, at 4:19 PM, Andrew Me @.***> wrote:

Sorry Ira,

wrong destination, meant to merge to my own repo for testing. please remove

— Reply to this email directly, view it on GitHub https://github.com/iklein99/homebridge-smartthings/pull/99#issuecomment-1338181174, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABG55ESNUE3RWYMH22KX2O3WLZL6LANCNFSM6AAAAAASUW7M7I. You are receiving this because you commented.

veonua commented 1 year ago

you are welcome to do so. Yes, the changes are up to date to the current master.

please let me know If you have any hints on how to move code from a local machine to rpi for tests

iklein99 commented 1 year ago

You should be able to use npm pack and then scp the file over to your device. Then from there, you should be able to use npm install within your homebridge directory.

On Dec 5, 2022, at 4:36 PM, Andrew Me @.***> wrote:

you are welcome to do so. Yes, the changes are up to date to the current master.

please let me know If you have any hints on how to move code from a local machine to rpi for tests

— Reply to this email directly, view it on GitHub https://github.com/iklein99/homebridge-smartthings/pull/99#issuecomment-1338208368, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABG55ERXJAL2F47M2MRZVBLWLZN6JANCNFSM6AAAAAASUW7M7I. You are receiving this because you commented.