Add started and finished times to Job

ilastik / cloud_ilastik

APIs for running ilastik inside HPB infra

Other

1 stars 0 forks source link

Add started and finished times to Job #50

Closed emilmelnikov closed 4 years ago

emilmelnikov commented 4 years ago

Add "started_on" and "finished_on" fields to the Job model.
Add the "Running Time" column to the project job list view.

Other changes:

Remove the row number field from the project job list view: job ID should be sufficient for debugging.
Add full job ID tooltip.
Change submission time tooltip from short human-readable format to full date string in order to provide more information.

Closes https://github.com/ilastik/cloud_ilastik/issues/44.

m-novikov commented 4 years ago

Great! There is a problem though we use filter(...).update(...) invocation for state transitions. This won't call save method leaving finished and updated fields not populated. We discussed it with @Tomaz-Vieira and the idea is to move state transitions to a custom model.Manager which will ensure we have our state machine in one place and everything uses the same pattern. filter(status=..., pk=...).update(status=new_status) and check number of matched rows.