search

ilayn / harold

An open-source systems and controls toolbox for Python3
MIT License
172 stars 19 forks source link

raise ValueError instead of IndexError #60

Closed namannimmo10 closed 4 years ago

namannimmo10 commented 4 years ago

I was going through the codebase (to take some ideas) and I think a ValueError would be more appropriate here.

namannimmo10 commented 4 years ago

Also: I do feel like some of the functionality is not tested properly. I'll add more tests when I have time! :)

ilayn commented 4 years ago

That's correct. I ran out of steam while writing those parts and went on for new features. Testing of these parts are sour points indeed.

Thanks though I hope you get good ideas out of it.