ilcato / homebridge-Fibaro-HC2

Homebridge plugin for Fibaro Home Center 2 (and Home Center Lite ...)
Apache License 2.0
67 stars 27 forks source link

Danalock Siri #136

Open MindaugasRam opened 5 years ago

MindaugasRam commented 5 years ago

Hi, plugin works great, thanks for it. I have only issue with Siri. When I ask Siri to open or close lock, it does but responses it was unable to do it. Home kit app works perfectly. Just Siri responses are faulty. Any thoughts how to fix it. Thanks

ilcato commented 5 years ago

No idea. I do not have such a device.

MindaugasRam commented 5 years ago

This is what I am getting in logs, maybe it might help you

[2/7/2019, 9:50:03 PM] [FibaroHC2] Setting value to device: 47 parameter: Lock Target State [2/7/2019, 9:50:03 PM] [FibaroHC2] Command: unsecure, value: 0, to: 47 [2/7/2019, 9:50:03 PM] [FibaroHC2] Getting value from device: 47 parameter: Lock Current State [2/7/2019, 9:50:03 PM] [FibaroHC2] Sent event: hb_fhc2_value_set, to: PUT KEY OF YOUR MAKER CHANNEL HERE (USED TO SIGNAL EVENTS TO THE OUTSIDE), for 47 [2/7/2019, 9:50:04 PM] [FibaroHC2] Getting value from device: 47 parameter: Lock Target State [2/7/2019, 9:50:05 PM] [FibaroHC2] There was a problem setting value to Lock: 47 [2/7/2019, 9:50:05 PM] [FibaroHC2] Sent event: hb_fhc2_lock_error, to: PUT KEY OF YOUR MAKER CHANNEL HERE (USED TO SIGNAL EVENTS TO THE OUTSIDE), for 47 [2/7/2019, 9:50:09 PM] [FibaroHC2] Updating value for device: 47 parameter: Lock Current State, value: false [2/7/2019, 9:50:09 PM] [FibaroHC2] Updating value for device: 47 parameter: Lock Target State, value: false [2/7/2019, 9:50:09 PM] [FibaroHC2] Sent event: hb_fhc2_value_get, to: PUT KEY OF YOUR MAKER CHANNEL HERE (USED TO SIGNAL EVENTS TO THE OUTSIDE), for 47 [2/7/2019, 9:50:09 PM] [FibaroHC2] Sent event: hb_fhc2_value_get, to: PUT KEY OF YOUR MAKER CHANNEL HERE (USED TO SIGNAL EVENTS TO THE OUTSIDE), for 47

carlittoer commented 5 years ago

Hi,

I have the same issue as well. All works, but Siri sometimes responds that it wasn't able to unlock while the lock really unlocks... How can I help?

ilcato commented 5 years ago

@MindaugasRam, I don't think it is related to the issue but I see a misconfiguration from your logs. Remove in config.json the rows containing: IFTTTmakerkey enableIFTTTnotification

and do not forget to remove the last ","

MindaugasRam commented 5 years ago

Thanks. I fixed that. But as you said it is not relaited to danalock. Still getting that Siri error.

MindaugasRam commented 5 years ago

@ilcato I found that someone managed to fix that on viera https://github.com/damianxd/homebridge-vera/pull/79/commits/c59f269d8a84cca11377e57cc8cdad484d7b2f6f. If you could look into it, when you have time, and fix as well if it is possible. Thanks

ilcato commented 5 years ago

Can you post a clean log?

MindaugasRam commented 5 years ago

[3/7/2019, 8:35:41 PM] [FibaroHC2] didFinishLaunching. [3/7/2019, 8:35:41 PM] Homebridge is running on port 51826. [3/7/2019, 8:35:41 PM] [FibaroHC2] Loading accessories [3/7/2019, 8:35:41 PM] [FibaroHC2] Added/changed accessory: Saliono sviesa [3/7/2019, 8:35:41 PM] [FibaroHC2] Added/changed accessory: Beatrices lempa [3/7/2019, 8:35:41 PM] [FibaroHC2] Added/changed accessory: Miegamo akis [3/7/2019, 8:35:41 PM] [FibaroHC2] Added/changed accessory: Miegamo temp [3/7/2019, 8:35:41 PM] [FibaroHC2] Added/changed accessory: Miegamo sviesa [3/7/2019, 8:35:41 PM] [FibaroHC2] Added/changed accessory: Paradines durys [3/7/2019, 8:35:41 PM] [FibaroHC2] Added/changed accessory: Kosto akis [3/7/2019, 8:35:41 PM] [FibaroHC2] Added/changed accessory: Kosto temp [3/7/2019, 8:35:41 PM] [FibaroHC2] Added/changed accessory: Kosto sviesa [3/7/2019, 8:35:41 PM] [FibaroHC2] Added/changed accessory: Gaisro sensorius [3/7/2019, 8:35:41 PM] [FibaroHC2] Added/changed accessory: Beatrices temp [3/7/2019, 8:35:41 PM] [FibaroHC2] Added/changed accessory: Naktine lempa [3/7/2019, 8:35:41 PM] [FibaroHC2] Added/changed accessory: Apple TV [3/7/2019, 8:36:22 PM] [FibaroHC2] Getting value from device: 47 parameter: Lock Current State [3/7/2019, 8:36:36 PM] [FibaroHC2] Setting value to device: 47 parameter: Lock Target State [3/7/2019, 8:36:36 PM] [FibaroHC2] Command: unsecure, value: 0, to: 47 [3/7/2019, 8:36:36 PM] [FibaroHC2] Getting value from device: 47 parameter: Lock Current State [3/7/2019, 8:36:37 PM] [FibaroHC2] Getting value from device: 47 parameter: Lock Target State [3/7/2019, 8:36:39 PM] [FibaroHC2] There was a problem setting value to Lock: 47 [3/7/2019, 8:36:41 PM] [FibaroHC2] Updating value for device: 47 parameter: Lock Current State, value: false [3/7/2019, 8:36:41 PM] [FibaroHC2] Updating value for device: 47 parameter: Lock Target State, value: false [3/7/2019, 8:37:31 PM] [FibaroHC2] Updating value for device: 65 parameter: Current Temperature, value: 21.80 [3/7/2019, 8:37:31 PM] [FibaroHC2] Updating value for device: 65 parameter: Current Temperature, value: 21.80

MindaugasRam commented 5 years ago

When I am asking siri door status (8:36:22), it says without problem and no errors. Just when I am asking to lock or unlock I am having that issue.

ilcato commented 5 years ago

Let me recap: the problem is that you see the following line in the log: There was a problem setting value to Lock: 47 but the command you asked is correctly executed?

MindaugasRam commented 5 years ago

Yes. Command to lock or unlock doors is executed correctly, but Siri says “I wasn’t able to lock/unlock doors”. If I am asking Siri “what is door status” it answers correctly.

ilcato commented 5 years ago

Which value did you put into doorlocktimeout parameter?

MindaugasRam commented 5 years ago

"doorlocktimeout": "3"

carlittoer commented 5 years ago

In my case, changing doorlocktimeout values is not affecting the behavior. I tried 0, 3 (the time needed for the lock and actually fully lock) and higher values.

What is this parameter used for really?

On Fri, Mar 8, 2019 at 10:54 AM ilcato notifications@github.com wrote:

Which value did you put into doorlocktimeout parameter?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/ilcato/homebridge-Fibaro-HC2/issues/136#issuecomment-470853748, or mute the thread https://github.com/notifications/unsubscribe-auth/AsX6ZrSjPo-kWXqahmfvRdCowfE-4Fycks5vUiU3gaJpZM4ap3Dj .

ilcato commented 5 years ago

In my case, changing doorlocktimeout values is not affecting the behavior. I tried 0, 3 (the time needed for the lock and actually fully lock) and higher values. What is this parameter used for really?

IT should signal via IFTTT a mismatch between the command sent to the lock and the real status after N seconds.

@MindaugasRam put it to 0 or better remove the line from the config.json and try again please.

carlittoer commented 5 years ago

So if you're not using IFTT, it's not needed. Right ?

On Fri, Mar 8, 2019 at 11:44 AM ilcato notifications@github.com wrote:

In my case, changing doorlocktimeout values is not affecting the behavior. I tried 0, 3 (the time needed for the lock and actually fully lock) and higher values. What is this parameter used for really?

… <#m-4142118382916493341>

IT should signal via IFTT a mismatch between the command sent to the lock and the real status after N seconds.

@MindaugasRam https://github.com/MindaugasRam put it to 0 or better remove the line from the config.json and try again please.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/ilcato/homebridge-Fibaro-HC2/issues/136#issuecomment-470868125, or mute the thread https://github.com/notifications/unsubscribe-auth/AsX6Zh6rO2Oh5eKL0ZISiQby59yWwDvqks5vUjDtgaJpZM4ap3Dj .

ilcato commented 5 years ago

So if you're not using IFTT, it's not needed. Right ?

Correct

MindaugasRam commented 5 years ago

I deleted all line. Still same

MindaugasRam commented 5 years ago

it works good with Siri Shortcuts

ilcato commented 5 years ago

@ilcato I found that someone managed to fix that on viera damianxd/homebridge-vera@c59f269. If you could look into it, when you have time, and fix as well if it is possible. Thanks

@MindaugasRam, what did you find in this commit that let you think about a solution ?

ilcato commented 5 years ago

@MindaugasRam, can you send me the configuration of the device through the rest api?

MindaugasRam commented 5 years ago

I've been searching and found this https://github.com/ptz0n/homebridge-verisure/issues/29, but I am not familiar with coding so thought you might be able to see that code and maybe find solution for yours :)

MindaugasRam commented 5 years ago

rest api - what do you mean? I am running homebridge in docker on synology nas, where you want me to look for it?

ilcato commented 5 years ago

rest api - what do you mean? I am running homebridge in docker on synology nas, where you want me to look for it?

connect to http://HOME_BRIDGE_IP/docs

select devices

insert the device id of the lock

read the response and sen it to me.

MindaugasRam commented 5 years ago

http://HOME_BRIDGE_IP:port/docs - brings me to homebridge home page

carlittoer commented 5 years ago

{"id":250,"name":"Doorlock","roomID":17,"type":"com.fibaro.doorLock","baseType":"com.fibaro.securityMonitoring","enabled":true,"visible":true,"isPlugin":false,"parentId":199,"remoteGatewayId":0,"interfaces":["accessControlEvent","battery","fibaroFirmwareUpdate","zwave","zwaveAlarm"],"properties":{"parameters":[],"pollingTimeSec":0,"zwaveCompany":"Poly-control","zwaveInfo":"3,4,61","zwaveVersion":"1.2","alarmLevel":"0","alarmType":"0","batteryLevel":"70","batteryLowNotification":"true","categories":"[\"security\"]","configured":true,"dead":"false","deadReason":"","defInterval":"0","deviceControlType":"0","deviceIcon":"79","emailNotificationID":"0","emailNotificationType":"0","endPointId":"0","firmwareUpdate":"{\"info\":\"\",\"progress\":0,\"status\":\"UpToDate\",\"updateVersion\":\"1.2\"}","log":"","logTemp":"","manufacturer":"","markAsDead":"true","maxInterval":"0","minInterval":"0","model":"","nodeId":"39","parametersTemplate":"0","productInfo":"1,14,0,9,0,1,1,2","pushNotificationID":"0","pushNotificationType":"0","remoteGatewayId":"0","saveLogs":"true","secured":"0","serialNumber":"h'————-","smsNotificationID":"0","smsNotificationType":"0","stepInterval":"0","updateVersion":"","useTemplate":"false","userDescription":"","value":"false"},"actions":{"abortUpdate":1,"reconfigure":0,"retryUpdate":1,"secure":0,"setInterval":1,"startUpdate":1,"unsecure":0,"updateFirmware":1},"created":1551769772,"modified":1551769772,"sortOrder":94} On Fri, Mar 8, 2019 at 7:31 PM MindaugasRam notifications@github.com wrote:

http://HOME_BRIDGE_IP:port/docs - brings me to homebridge home page

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/ilcato/homebridge-Fibaro-HC2/issues/136#issuecomment-471010574, or mute the thread https://github.com/notifications/unsubscribe-auth/AsX6Zj8DbnZ0Qu2rL51l4hpNCpRDb5Kaks5vUp59gaJpZM4ap3Dj .

ilcato commented 5 years ago

Thanks @carlittoer

ilcato commented 5 years ago

@MindaugasRam, @carlittoer, when the problem arise is the lock status reported by the Homecenter app correct? How much time does it take, after the voice command, to change the lock state for both the physical device and the HomeCenter app widget?

MindaugasRam commented 5 years ago

Homecenter app status is correct. Siri answers in no time, like straight away. It takes about 3-5 secs to change lock status. Homecenter app is quicker to report correct value, diferrence 2-3 secs

MindaugasRam commented 5 years ago

when the device (lock) starts to lock or unlock, siri gives the error message.

carlittoer commented 5 years ago

Agree, Siri instantly responds with the Sorry msg... the status in HC2 is updated in the same time correctly.

Comparing the 2 jsons, when locked, the only properties that change are :

value: false becomes true secured: 0 becomes 255

On Fri, Mar 8, 2019 at 7:51 PM MindaugasRam notifications@github.com wrote:

when the device (lock) starts to lock or unlock, siri gives the error message.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ilcato/homebridge-Fibaro-HC2/issues/136#issuecomment-471016753, or mute the thread https://github.com/notifications/unsubscribe-auth/AsX6ZkexMSTGVpaGH8cRGh2F8b-e1cljks5vUqMdgaJpZM4ap3Dj .

MindaugasRam commented 5 years ago

guys could you please help me to do that rest api and get my values. Do I need some additional software or different browser (using safari)? I know, I might be very behind you, but still want to learn. Thanks

carlittoer commented 5 years ago

Sure !

No additional software needed. You need to be logged in though.

Directly from your browser go to:

http:///api/devices

For a specific device:

http:///api/devices/

For the API reference :

http:///docs

On Fri, Mar 8, 2019 at 9:22 PM MindaugasRam notifications@github.com wrote:

guys could you please help me to do that rest api and get my values. Do I need some additional software or different browser (using safari)? I know, I might be very behind you, but still want to learn. Thanks

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ilcato/homebridge-Fibaro-HC2/issues/136#issuecomment-471045463, or mute the thread https://github.com/notifications/unsubscribe-auth/AsX6ZrWxDESzzFqRPzy8eFjSD2CrPBrRks5vUrhtgaJpZM4ap3Dj .

MindaugasRam commented 5 years ago

Thanks @carlittoer

This is mine:{"id":47,"name":"Paradines durys","roomID":3,"type":"com.fibaro.doorLock","baseType":"com.fibaro.securityMonitoring","enabled":true,"visible":true,"isPlugin":false,"parentId":46,"remoteGatewayId":0,"interfaces":["accessControlEvent","battery","fibaroFirmwareUpdate","pinCode","zwave","zwaveAlarm"],"properties":{"parameters":[{"id":1,"size":1,"value":0},{"id":2,"size":1,"value":3},{"id":3,"size":1,"value":1},{"id":4,"size":1,"value":9},{"id":5,"size":1,"value":0},{"id":6,"size":1,"value":1},{"id":7,"size":1,"value":0},{"id":8,"size":1,"value":0},{"id":9,"size":1,"value":0},{"id":10,"size":1,"value":0},{"id":11,"size":1,"value":0},{"id":12,"size":1,"value":0}],"pollingTimeSec":0,"zwaveCompany":"Poly-control","zwaveInfo":"3,4,24","zwaveVersion":"1.4","alarmLevel":"0","alarmType":"0","batteryLevel":"44","batteryLowNotification":"true","categories":"[\"security\"]","configured":true,"dead":"false","deadReason":"","defInterval":"0","deviceControlType":"0","deviceIcon":"79","emailNotificationID":"0","emailNotificationType":"0","endPointId":"0","firmwareUpdate":"{\"info\":\"\",\"progress\":0,\"status\":\"UpToDate\",\"updateVersion\":\"1.4\"}","log":"","logTemp":"","manufacturer":"","markAsDead":"true","maxInterval":"0","maxUsers":"20","minInterval":"0","model":"","nodeId":"13","parametersTemplate":"743","productInfo":"1,14,0,8,0,2,1,4","pushNotificationID":"0","pushNotificationType":"0","remoteGatewayId":"0","saveLogs":"true","secured":"0","serialNumber":"h'e0e50054df74","smsNotificationID":"0","smsNotificationType":"0","stepInterval":"0","updateVersion":"","useTemplate":"true","userCodes":"[{\"id\":1,\"name\":\"\",\"status\":\"Available\",\"update\":\"Ok\"},{\"id\":2,\"name\":\"\",\"status\":\"Available\",\"update\":\"Ok\"},{\"id\":3,\"name\":\"\",\"status\":\"Available\",\"update\":\"Ok\"},{\"id\":4,\"name\":\"\",\"status\":\"Available\",\"update\":\"Ok\"},{\"id\":5,\"name\":\"\",\"status\":\"Available\",\"update\":\"Ok\"},{\"id\":6,\"name\":\"\",\"status\":\"Available\",\"update\":\"Ok\"},{\"id\":7,\"name\":\"\",\"status\":\"Available\",\"update\":\"Ok\"},{\"id\":8,\"name\":\"\",\"status\":\"Available\",\"update\":\"Ok\"},{\"id\":9,\"name\":\"\",\"status\":\"Available\",\"update\":\"Ok\"},{\"id\":10,\"name\":\"\",\"status\":\"Available\",\"update\":\"Ok\"},{\"id\":11,\"name\":\"\",\"status\":\"Available\",\"update\":\"Ok\"},{\"id\":12,\"name\":\"\",\"status\":\"Available\",\"update\":\"Ok\"},{\"id\":13,\"name\":\"\",\"status\":\"Available\",\"update\":\"Ok\"},{\"id\":14,\"name\":\"\",\"status\":\"Available\",\"update\":\"Ok\"},{\"id\":15,\"name\":\"\",\"status\":\"Available\",\"update\":\"Ok\"},{\"id\":16,\"name\":\"\",\"status\":\"Available\",\"update\":\"Ok\"},{\"id\":17,\"name\":\"\",\"status\":\"Available\",\"update\":\"Ok\"},{\"id\":18,\"name\":\"\",\"status\":\"Available\",\"update\":\"Ok\"},{\"id\":19,\"name\":\"\",\"status\":\"Available\",\"update\":\"Ok\"},{\"id\":20,\"name\":\"\",\"status\":\"Available\",\"update\":\"Ok\"}]","userDescription":"","value":"false"},"actions":{"abortUpdate":1,"getMaxUsers":0,"getUserCode":1,"reconfigure":0,"retryUpdate":1,"secure":0,"setInterval":1,"setUserCode":4,"startUpdate":1,"unsecure":0,"updateFirmware":1},"created":1552061285,"modified":1552061285,"sortOrder":28}

ilcato commented 5 years ago

What’s the value for poller interval?

MindaugasRam commented 5 years ago

"pollerperiod": "2",

MindaugasRam commented 5 years ago

in fibaro: Device pooling time interval: 300

ilcato commented 5 years ago

Can you try 1 instead of 2?

MindaugasRam commented 5 years ago

did. still getting error

ilcato commented 5 years ago

Can you try to replace the following file in your setup:

https://raw.githubusercontent.com/ilcato/homebridge-Fibaro-HC2/master/dist/setFunctions.js

?

MindaugasRam commented 5 years ago

I have changed. Restarted. Same error

ilcato commented 5 years ago

@MindaugasRam , @carlittoer which version of node.js and Homebridge do you have?

MindaugasRam commented 5 years ago

homebridge-config-ui-x v3.9.6 - node.js v10.15.2

MindaugasRam commented 5 years ago

homebridge Version 0.4.46

ilcato commented 5 years ago

@MindaugasRam can you try again with this file:

https://raw.githubusercontent.com/ilcato/homebridge-Fibaro-HC2/master/dist/setFunctions.js

carlittoer commented 5 years ago

Hi,

Not sure if in the correct direction, but I tried to increase the timeout value in setTimeout and placed a log inside. Siri responds with sorry even before this code is being executed.

Anything you want me try? On Sat, Mar 9, 2019 at 10:52 PM ilcato notifications@github.com wrote:

@MindaugasRam https://github.com/MindaugasRam can you try again with this file:

https://raw.githubusercontent.com/ilcato/homebridge-Fibaro-HC2/master/dist/setFunctions.js

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ilcato/homebridge-Fibaro-HC2/issues/136#issuecomment-471220931, or mute the thread https://github.com/notifications/unsubscribe-auth/AsX6ZgPvdRSmFGgkRrpRAwOxLoqnmYT0ks5vVB8ogaJpZM4ap3Dj .

ilcato commented 5 years ago

Interesting. Try with 0.

carlittoer commented 5 years ago

Did not work either.

Is there a way to make Siri wait before giving back an answer?

Is this a callback hell as referred to here? https://github.com/nfarina/homebridge/issues/6

The other commit in the Vera project that @MindaugasRam has mentioned uses Promises instead of callbacks.

On Sun, Mar 10, 2019 at 9:05 AM ilcato notifications@github.com wrote:

Interesting. Try with 0.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ilcato/homebridge-Fibaro-HC2/issues/136#issuecomment-471253141, or mute the thread https://github.com/notifications/unsubscribe-auth/AsX6ZiPWCXCub0L-8jHUNDB0fwAViYS9ks5vVK61gaJpZM4ap3Dj .

ilcato commented 5 years ago

Got the idea but I based almost all of the plugin on promises. Can you try changing both: https://raw.githubusercontent.com/ilcato/homebridge-Fibaro-HC2/master/dist/setFunctions.js https://raw.githubusercontent.com/ilcato/homebridge-Fibaro-HC2/master/dist/index.js

?

carlittoer commented 5 years ago

Thanks again for your great support on this.

I am sorry to say it did not work.

On Sun, Mar 10, 2019 at 6:09 PM ilcato notifications@github.com wrote:

Got the idea but I based almost all of the plugin on promises. Can you try changing both:

https://raw.githubusercontent.com/ilcato/homebridge-Fibaro-HC2/master/dist/setFunctions.js

https://raw.githubusercontent.com/ilcato/homebridge-Fibaro-HC2/master/dist/index.js

?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ilcato/homebridge-Fibaro-HC2/issues/136#issuecomment-471319465, or mute the thread https://github.com/notifications/unsubscribe-auth/AsX6ZuPPFOOAJxOWOms7NX__SWUG4VELks5vVS5XgaJpZM4ap3Dj .