search

ilcato / homebridge-Fibaro-HC2

Homebridge plugin for Fibaro Home Center 2 (and Home Center Lite ...)
Apache License 2.0
66 stars 27 forks source link

Danalock Siri #136

Open MindaugasRam opened 5 years ago

MindaugasRam commented 5 years ago

Hi, plugin works great, thanks for it. I have only issue with Siri. When I ask Siri to open or close lock, it does but responses it was unable to do it. Home kit app works perfectly. Just Siri responses are faulty. Any thoughts how to fix it. Thanks

Krillle commented 5 years ago

@MindaugasRam This is good to hear. I assumed so already reading the conversation. How did you install this fix? Via: sudo npm install -g git+https://github.com/ilcato/homebridge-Fibaro-HC2.git

@ilcato May I ask to update the package at npm to 2.2.1.

MindaugasRam commented 5 years ago

@krillle yes you have to update it manually. Copy paste. And restart

Krillle commented 5 years ago

@MindaugasRam Thanks for your answer. I think I will wait for the update at npm then.

ilcato commented 5 years ago

Published current master version in pm as 2.2.1.

@Krillle, please install the upgrade and check if it works for you.

@carlittoer, @MindaugasRam please install from nom and report potential issues back here.

Krillle commented 5 years ago

@ilcato Thanks for updating npm. I tried to update my installation, but does not install. It hangs here:

sudo npm install -g homebridge-fibaro-hc2
[..................] \ fetchMetadata: sill resolveWithNewModule homebridge-fibaro-hc2@2.2.1 checking installable status

No clue why.

ilcato commented 5 years ago

@Krillle, try to uninstall and reinstall it.

Krillle commented 5 years ago

@ilcato Uninstall went smooth. Install hangs again. Now I am stuck.

pi@Homebridge:~ $ sudo npm uninstall -g homebridge-fibaro-hc2
removed 50 packages in 2.477s
pi@Homebridge:~ $ sudo npm install -g homebridge-fibaro-hc2
[..................] / rollbackFailedOptional: verb npm-session 9a4d14dcbfe0a5c0
Krillle commented 5 years ago

@ilcato Here is some more detailed error message:

pi@Homebridge:~ $ sudo npm install -g homebridge-fibaro-hc2
npm ERR! Unexpected end of JSON input while parsing near '...,"@types/convert-sour'

npm ERR! A complete log of this run can be found in:
npm ERR!     /root/.npm/_logs/2019-04-08T14_15_31_171Z-debug.log
pi@Homebridge:~ $

Do you need the full log?

ilcato commented 5 years ago

yes

Krillle commented 5 years ago

Here it is: /root/.npm/_logs/2019-04-08T14_15_31_171Z-debug.log

0 info it worked if it ends with ok
1 verbose cli [ '/usr/bin/node',
1 verbose cli   '/usr/bin/npm',
1 verbose cli   'install',
1 verbose cli   '-g',
1 verbose cli   'homebridge-fibaro-hc2' ]
2 info using npm@5.6.0
3 info using node@v8.11.4
4 verbose npm-session c1c56a02f0859a83
5 silly install loadCurrentTree
6 silly install readGlobalPackageData
7 http fetch GET 304 https://registry.npmjs.org/homebridge-fibaro-hc2 39070ms attempt #2 (from cache)
8 silly pacote tag manifest for homebridge-fibaro-hc2@latest fetched in 39237ms
9 silly install loadIdealTree
10 silly install cloneCurrentTreeToIdealTree
11 silly install loadShrinkwrap
12 silly install loadAllDepsIntoIdealTree
13 silly resolveWithNewModule homebridge-fibaro-hc2@2.2.1 checking installable status
14 http fetch GET 304 https://registry.npmjs.org/request 6711ms (from cache)
15 silly pacote range manifest for request@^2.88.0 fetched in 6750ms
16 silly resolveWithNewModule request@2.88.0 checking installable status
17 http fetch GET 200 https://registry.npmjs.org/typescript 465454ms
18 silly fetchPackageMetaData error for typescript@^2.2.2 Unexpected end of JSON input while parsing near '...,"@types/convert-sour'
19 verbose stack SyntaxError: Unexpected end of JSON input while parsing near '...,"@types/convert-sour'
19 verbose stack     at JSON.parse (<anonymous>)
19 verbose stack     at parseJson (/usr/lib/node_modules/npm/node_modules/pacote/node_modules/make-fetch-happen/node_modules/node-fetch-npm/node_modules/json-parse-better-errors/index.js:7:17)
19 verbose stack     at consumeBody.call.then.buffer (/usr/lib/node_modules/npm/node_modules/pacote/node_modules/make-fetch-happen/node_modules/node-fetch-npm/src/body.js:96:50)
19 verbose stack     at <anonymous>
19 verbose stack     at process._tickCallback (internal/process/next_tick.js:188:7)
20 verbose cwd /home/pi
21 verbose Linux 4.14.50-v7+
22 verbose argv "/usr/bin/node" "/usr/bin/npm" "install" "-g" "homebridge-fibaro-hc2"
23 verbose node v8.11.4
24 verbose npm  v5.6.0
25 error Unexpected end of JSON input while parsing near '...,"@types/convert-sour'
26 verbose exit [ 1, true ]
Krillle commented 5 years ago

It seems it was a local problem. sudo npm cache clean --force solved it. Now 2.2.1 did install. I got a nasty WARN using --force I sure hope you know what you are doing. But I hope it it did not break anything,

Krillle commented 5 years ago

@ilcato I checked with 2.2.1: After first try failed it does now work as it should. Thanks for fixing!

Krillle commented 5 years ago

@ilcato I installed in office and at home now. Actually it works most of the cases, but not always. There is two types of weird behavior:

A) Door is immediately unlocked after being locked - and then declared correctly as "I could not lock door". This happened several times.

B) Randomly Siri states she could not lock or unlock the door, despite she did. Can be she has this problem only opening the doors. But I can't find a reproducible scheme. In most of the cases this "could not open" message came after the lock stopped operating, but once the message came while it was still operating.

Here is the log excerpt to such a behavior:

Apr 08 21:25:18 Homebridge homebridge[3775]: [2019-4-8 21:25:18] [FibaroHC2] Setting value to device:  233  parameter: Lock Target State
Apr 08 21:25:18 Homebridge homebridge[3775]: [2019-4-8 21:25:18] [FibaroHC2] Setting value to device:  273  parameter: Lock Target State
Apr 08 21:25:18 Homebridge homebridge[3775]: [2019-4-8 21:25:18] [FibaroHC2] Command:  secure, value: 0, to: 233
Apr 08 21:25:18 Homebridge homebridge[3775]: [2019-4-8 21:25:18] [FibaroHC2] Command:  secure, value: 0, to: 273
Apr 08 21:25:18 Homebridge homebridge[3775]: [2019-4-8 21:25:18] [FibaroHC2] Getting value from device:  233  parameter: Lock Current State
Apr 08 21:25:18 Homebridge homebridge[3775]: [2019-4-8 21:25:18] [FibaroHC2] Getting value from device:  273  parameter: Lock Current State
Apr 08 21:25:22 Homebridge homebridge[3775]: [2019-4-8 21:25:22] [FibaroHC2] Getting value from device:  273  parameter: Lock Target State
Apr 08 21:25:22 Homebridge homebridge[3775]: [2019-4-8 21:25:22] [FibaroHC2] Getting value from device:  233  parameter: Lock Target State
Apr 08 21:25:24 Homebridge homebridge[3775]: [2019-4-8 21:25:24] [FibaroHC2] Updating value for device:  273  parameter: Lock Current State, value: true
Apr 08 21:25:24 Homebridge homebridge[3775]: [2019-4-8 21:25:24] [FibaroHC2] Updating value for device:  273  parameter: Lock Target State, value: true
Apr 08 21:25:25 Homebridge homebridge[3775]: [2019-4-8 21:25:25] [FibaroHC2] Getting value from device:  233  parameter: Lock Current State
Apr 08 21:25:25 Homebridge homebridge[3775]: [2019-4-8 21:25:25] [FibaroHC2] Getting value from device:  273  parameter: Lock Current State
Apr 08 21:25:34 Homebridge homebridge[3775]: [2019-4-8 21:25:34] [FibaroHC2] Setting value to device:  233  parameter: Lock Target State
Apr 08 21:25:34 Homebridge homebridge[3775]: [2019-4-8 21:25:34] [FibaroHC2] Setting value to device:  273  parameter: Lock Target State
Apr 08 21:25:34 Homebridge homebridge[3775]: [2019-4-8 21:25:34] [FibaroHC2] Command:  unsecure, value: 0, to: 233
Apr 08 21:25:34 Homebridge homebridge[3775]: [2019-4-8 21:25:34] [FibaroHC2] Command:  unsecure, value: 0, to: 273
Apr 08 21:25:34 Homebridge homebridge[3775]: [2019-4-8 21:25:34] [FibaroHC2] Getting value from device:  233  parameter: Lock Current State
Apr 08 21:25:34 Homebridge homebridge[3775]: [2019-4-8 21:25:34] [FibaroHC2] Getting value from device:  273  parameter: Lock Current State
Apr 08 21:25:38 Homebridge homebridge[3775]: [2019-4-8 21:25:38] [FibaroHC2] Getting value from device:  273  parameter: Lock Target State
Apr 08 21:25:38 Homebridge homebridge[3775]: [2019-4-8 21:25:38] [FibaroHC2] Getting value from device:  233  parameter: Lock Target State
Apr 08 21:25:39 Homebridge homebridge[3775]: [2019-4-8 21:25:39] [FibaroHC2] Updating value for device:  173  parameter: Current Temperature, value: 25.90
Apr 08 21:25:39 Homebridge homebridge[3775]: [2019-4-8 21:25:39] [FibaroHC2] Updating value for device:  273  parameter: Lock Current State, value: false
Apr 08 21:25:39 Homebridge homebridge[3775]: [2019-4-8 21:25:39] [FibaroHC2] Updating value for device:  273  parameter: Lock Target State, value: false
Apr 08 21:25:41 Homebridge homebridge[3775]: [2019-4-8 21:25:41] [FibaroHC2] There was a problem setting value to Lock:  233
Apr 08 21:25:51 Homebridge homebridge[3775]: [2019-4-8 21:25:51] [FibaroHC2] Setting value to device:  233  parameter: Lock Target State
Apr 08 21:25:51 Homebridge homebridge[3775]: [2019-4-8 21:25:51] [FibaroHC2] Setting value to device:  273  parameter: Lock Target State
Apr 08 21:25:51 Homebridge homebridge[3775]: [2019-4-8 21:25:51] [FibaroHC2] Command:  secure, value: 0, to: 233
Apr 08 21:25:51 Homebridge homebridge[3775]: [2019-4-8 21:25:51] [FibaroHC2] Command:  secure, value: 0, to: 273
Apr 08 21:25:51 Homebridge homebridge[3775]: [2019-4-8 21:25:51] [FibaroHC2] Getting value from device:  233  parameter: Lock Current State
Apr 08 21:25:51 Homebridge homebridge[3775]: [2019-4-8 21:25:51] [FibaroHC2] Getting value from device:  273  parameter: Lock Current State
Apr 08 21:25:55 Homebridge homebridge[3775]: [2019-4-8 21:25:55] [FibaroHC2] Getting value from device:  273  parameter: Lock Target State
Apr 08 21:25:55 Homebridge homebridge[3775]: [2019-4-8 21:25:55] [FibaroHC2] Getting value from device:  233  parameter: Lock Target State
Apr 08 21:25:59 Homebridge homebridge[3775]: [2019-4-8 21:25:59] [FibaroHC2] Updating value for device:  273  parameter: Lock Current State, value: true
Apr 08 21:25:59 Homebridge homebridge[3775]: [2019-4-8 21:25:59] [FibaroHC2] Updating value for device:  273  parameter: Lock Target State, value: true
Apr 08 21:26:08 Homebridge homebridge[3775]: [2019-4-8 21:26:08] [FibaroHC2] Setting value to device:  233  parameter: Lock Target State
Apr 08 21:26:08 Homebridge homebridge[3775]: [2019-4-8 21:26:08] [FibaroHC2] Setting value to device:  273  parameter: Lock Target State
Apr 08 21:26:08 Homebridge homebridge[3775]: [2019-4-8 21:26:08] [FibaroHC2] Command:  unsecure, value: 0, to: 273
Apr 08 21:26:08 Homebridge homebridge[3775]: [2019-4-8 21:26:08] [FibaroHC2] Command:  unsecure, value: 0, to: 233
Apr 08 21:26:08 Homebridge homebridge[3775]: [2019-4-8 21:26:08] [FibaroHC2] Getting value from device:  233  parameter: Lock Current State
Apr 08 21:26:08 Homebridge homebridge[3775]: [2019-4-8 21:26:08] [FibaroHC2] Getting value from device:  273  parameter: Lock Current State
Apr 08 21:26:12 Homebridge homebridge[3775]: [2019-4-8 21:26:12] [FibaroHC2] Getting value from device:  273  parameter: Lock Target State
Apr 08 21:26:12 Homebridge homebridge[3775]: [2019-4-8 21:26:12] [FibaroHC2] Getting value from device:  233  parameter: Lock Target State
Apr 08 21:26:13 Homebridge homebridge[3775]: [2019-4-8 21:26:13] [FibaroHC2] Updating value for device:  273  parameter: Lock Current State, value: false
Apr 08 21:26:13 Homebridge homebridge[3775]: [2019-4-8 21:26:13] [FibaroHC2] Updating value for device:  273  parameter: Lock Target State, value: false
Apr 08 21:26:15 Homebridge homebridge[3775]: [2019-4-8 21:26:15] [FibaroHC2] There was a problem setting value to Lock:  233
Apr 08 21:26:26 Homebridge homebridge[3775]: [2019-4-8 21:26:26] [FibaroHC2] Setting value to device:  233  parameter: Lock Target State
Apr 08 21:26:26 Homebridge homebridge[3775]: [2019-4-8 21:26:26] [FibaroHC2] Setting value to device:  273  parameter: Lock Target State
Apr 08 21:26:26 Homebridge homebridge[3775]: [2019-4-8 21:26:26] [FibaroHC2] Command:  secure, value: 0, to: 233
Apr 08 21:26:26 Homebridge homebridge[3775]: [2019-4-8 21:26:26] [FibaroHC2] Command:  secure, value: 0, to: 273
Apr 08 21:26:26 Homebridge homebridge[3775]: [2019-4-8 21:26:26] [FibaroHC2] Getting value from device:  233  parameter: Lock Current State
Apr 08 21:26:26 Homebridge homebridge[3775]: [2019-4-8 21:26:26] [FibaroHC2] Getting value from device:  273  parameter: Lock Current State
Apr 08 21:26:30 Homebridge homebridge[3775]: [2019-4-8 21:26:30] [FibaroHC2] Getting value from device:  273  parameter: Lock Target State
Apr 08 21:26:30 Homebridge homebridge[3775]: [2019-4-8 21:26:30] [FibaroHC2] Getting value from device:  233  parameter: Lock Target State
Apr 08 21:26:33 Homebridge homebridge[3775]: [2019-4-8 21:26:33] [FibaroHC2] Updating value for device:  273  parameter: Lock Current State, value: true
Apr 08 21:26:33 Homebridge homebridge[3775]: [2019-4-8 21:26:33] [FibaroHC2] Updating value for device:  273  parameter: Lock Target State, value: true
Apr 08 21:26:33 Homebridge homebridge[3775]: [2019-4-8 21:26:33] [FibaroHC2] Getting value from device:  233  parameter: Lock Current State
Apr 08 21:26:33 Homebridge homebridge[3775]: [2019-4-8 21:26:33] [FibaroHC2] Getting value from device:  273  parameter: Lock Current State
carlittoer commented 5 years ago

Hi !

How many times does your danalock turn to lock the door? One or two?

I found out that mine (2 turns) needs 4 seconds to complete the operation.

In that case timeout variables (currently inside the code) should be increased to 4s

On Mon, Apr 8, 2019 at 10:31 PM Christian Wegerhoff < notifications@github.com> wrote:

@ilcato https://github.com/ilcato I installed in office and at home now. Actually it works most of the cases, but not always. There is two types of weird behavior:

A) Door is immediately unlocked after being locked - and then declared correctly as "I could not lock door". This happened multiple times.

B) Randomly Siri states she could not lock or unlock the door, despite she did. Here is the low excerpt to such a random behavior:

Apr 08 21:25:18 Homebridge homebridge[3775]: [2019-4-8 21:25:18] [FibaroHC2] Setting value to device: 233 parameter: Lock Target State Apr 08 21:25:18 Homebridge homebridge[3775]: [2019-4-8 21:25:18] [FibaroHC2] Setting value to device: 273 parameter: Lock Target State Apr 08 21:25:18 Homebridge homebridge[3775]: [2019-4-8 21:25:18] [FibaroHC2] Command: secure, value: 0, to: 233 Apr 08 21:25:18 Homebridge homebridge[3775]: [2019-4-8 21:25:18] [FibaroHC2] Command: secure, value: 0, to: 273 Apr 08 21:25:18 Homebridge homebridge[3775]: [2019-4-8 21:25:18] [FibaroHC2] Getting value from device: 233 parameter: Lock Current State Apr 08 21:25:18 Homebridge homebridge[3775]: [2019-4-8 21:25:18] [FibaroHC2] Getting value from device: 273 parameter: Lock Current State Apr 08 21:25:22 Homebridge homebridge[3775]: [2019-4-8 21:25:22] [FibaroHC2] Getting value from device: 273 parameter: Lock Target State Apr 08 21:25:22 Homebridge homebridge[3775]: [2019-4-8 21:25:22] [FibaroHC2] Getting value from device: 233 parameter: Lock Target State Apr 08 21:25:24 Homebridge homebridge[3775]: [2019-4-8 21:25:24] [FibaroHC2] Updating value for device: 273 parameter: Lock Current State, value: true Apr 08 21:25:24 Homebridge homebridge[3775]: [2019-4-8 21:25:24] [FibaroHC2] Updating value for device: 273 parameter: Lock Target State, value: true Apr 08 21:25:25 Homebridge homebridge[3775]: [2019-4-8 21:25:25] [FibaroHC2] Getting value from device: 233 parameter: Lock Current State Apr 08 21:25:25 Homebridge homebridge[3775]: [2019-4-8 21:25:25] [FibaroHC2] Getting value from device: 273 parameter: Lock Current State Apr 08 21:25:34 Homebridge homebridge[3775]: [2019-4-8 21:25:34] [FibaroHC2] Setting value to device: 233 parameter: Lock Target State Apr 08 21:25:34 Homebridge homebridge[3775]: [2019-4-8 21:25:34] [FibaroHC2] Setting value to device: 273 parameter: Lock Target State Apr 08 21:25:34 Homebridge homebridge[3775]: [2019-4-8 21:25:34] [FibaroHC2] Command: unsecure, value: 0, to: 233 Apr 08 21:25:34 Homebridge homebridge[3775]: [2019-4-8 21:25:34] [FibaroHC2] Command: unsecure, value: 0, to: 273 Apr 08 21:25:34 Homebridge homebridge[3775]: [2019-4-8 21:25:34] [FibaroHC2] Getting value from device: 233 parameter: Lock Current State Apr 08 21:25:34 Homebridge homebridge[3775]: [2019-4-8 21:25:34] [FibaroHC2] Getting value from device: 273 parameter: Lock Current State Apr 08 21:25:38 Homebridge homebridge[3775]: [2019-4-8 21:25:38] [FibaroHC2] Getting value from device: 273 parameter: Lock Target State Apr 08 21:25:38 Homebridge homebridge[3775]: [2019-4-8 21:25:38] [FibaroHC2] Getting value from device: 233 parameter: Lock Target State Apr 08 21:25:39 Homebridge homebridge[3775]: [2019-4-8 21:25:39] [FibaroHC2] Updating value for device: 173 parameter: Current Temperature, value: 25.90 Apr 08 21:25:39 Homebridge homebridge[3775]: [2019-4-8 21:25:39] [FibaroHC2] Updating value for device: 273 parameter: Lock Current State, value: false Apr 08 21:25:39 Homebridge homebridge[3775]: [2019-4-8 21:25:39] [FibaroHC2] Updating value for device: 273 parameter: Lock Target State, value: false Apr 08 21:25:41 Homebridge homebridge[3775]: [2019-4-8 21:25:41] [FibaroHC2] There was a problem setting value to Lock: 233 Apr 08 21:25:51 Homebridge homebridge[3775]: [2019-4-8 21:25:51] [FibaroHC2] Setting value to device: 233 parameter: Lock Target State Apr 08 21:25:51 Homebridge homebridge[3775]: [2019-4-8 21:25:51] [FibaroHC2] Setting value to device: 273 parameter: Lock Target State Apr 08 21:25:51 Homebridge homebridge[3775]: [2019-4-8 21:25:51] [FibaroHC2] Command: secure, value: 0, to: 233 Apr 08 21:25:51 Homebridge homebridge[3775]: [2019-4-8 21:25:51] [FibaroHC2] Command: secure, value: 0, to: 273 Apr 08 21:25:51 Homebridge homebridge[3775]: [2019-4-8 21:25:51] [FibaroHC2] Getting value from device: 233 parameter: Lock Current State Apr 08 21:25:51 Homebridge homebridge[3775]: [2019-4-8 21:25:51] [FibaroHC2] Getting value from device: 273 parameter: Lock Current State Apr 08 21:25:55 Homebridge homebridge[3775]: [2019-4-8 21:25:55] [FibaroHC2] Getting value from device: 273 parameter: Lock Target State Apr 08 21:25:55 Homebridge homebridge[3775]: [2019-4-8 21:25:55] [FibaroHC2] Getting value from device: 233 parameter: Lock Target State Apr 08 21:25:59 Homebridge homebridge[3775]: [2019-4-8 21:25:59] [FibaroHC2] Updating value for device: 273 parameter: Lock Current State, value: true Apr 08 21:25:59 Homebridge homebridge[3775]: [2019-4-8 21:25:59] [FibaroHC2] Updating value for device: 273 parameter: Lock Target State, value: true Apr 08 21:26:08 Homebridge homebridge[3775]: [2019-4-8 21:26:08] [FibaroHC2] Setting value to device: 233 parameter: Lock Target State Apr 08 21:26:08 Homebridge homebridge[3775]: [2019-4-8 21:26:08] [FibaroHC2] Setting value to device: 273 parameter: Lock Target State Apr 08 21:26:08 Homebridge homebridge[3775]: [2019-4-8 21:26:08] [FibaroHC2] Command: unsecure, value: 0, to: 273 Apr 08 21:26:08 Homebridge homebridge[3775]: [2019-4-8 21:26:08] [FibaroHC2] Command: unsecure, value: 0, to: 233 Apr 08 21:26:08 Homebridge homebridge[3775]: [2019-4-8 21:26:08] [FibaroHC2] Getting value from device: 233 parameter: Lock Current State Apr 08 21:26:08 Homebridge homebridge[3775]: [2019-4-8 21:26:08] [FibaroHC2] Getting value from device: 273 parameter: Lock Current State Apr 08 21:26:12 Homebridge homebridge[3775]: [2019-4-8 21:26:12] [FibaroHC2] Getting value from device: 273 parameter: Lock Target State Apr 08 21:26:12 Homebridge homebridge[3775]: [2019-4-8 21:26:12] [FibaroHC2] Getting value from device: 233 parameter: Lock Target State Apr 08 21:26:13 Homebridge homebridge[3775]: [2019-4-8 21:26:13] [FibaroHC2] Updating value for device: 273 parameter: Lock Current State, value: false Apr 08 21:26:13 Homebridge homebridge[3775]: [2019-4-8 21:26:13] [FibaroHC2] Updating value for device: 273 parameter: Lock Target State, value: false Apr 08 21:26:15 Homebridge homebridge[3775]: [2019-4-8 21:26:15] [FibaroHC2] There was a problem setting value to Lock: 233 Apr 08 21:26:26 Homebridge homebridge[3775]: [2019-4-8 21:26:26] [FibaroHC2] Setting value to device: 233 parameter: Lock Target State Apr 08 21:26:26 Homebridge homebridge[3775]: [2019-4-8 21:26:26] [FibaroHC2] Setting value to device: 273 parameter: Lock Target State Apr 08 21:26:26 Homebridge homebridge[3775]: [2019-4-8 21:26:26] [FibaroHC2] Command: secure, value: 0, to: 233 Apr 08 21:26:26 Homebridge homebridge[3775]: [2019-4-8 21:26:26] [FibaroHC2] Command: secure, value: 0, to: 273 Apr 08 21:26:26 Homebridge homebridge[3775]: [2019-4-8 21:26:26] [FibaroHC2] Getting value from device: 233 parameter: Lock Current State Apr 08 21:26:26 Homebridge homebridge[3775]: [2019-4-8 21:26:26] [FibaroHC2] Getting value from device: 273 parameter: Lock Current State Apr 08 21:26:30 Homebridge homebridge[3775]: [2019-4-8 21:26:30] [FibaroHC2] Getting value from device: 273 parameter: Lock Target State Apr 08 21:26:30 Homebridge homebridge[3775]: [2019-4-8 21:26:30] [FibaroHC2] Getting value from device: 233 parameter: Lock Target State Apr 08 21:26:33 Homebridge homebridge[3775]: [2019-4-8 21:26:33] [FibaroHC2] Updating value for device: 273 parameter: Lock Current State, value: true Apr 08 21:26:33 Homebridge homebridge[3775]: [2019-4-8 21:26:33] [FibaroHC2] Updating value for device: 273 parameter: Lock Target State, value: true Apr 08 21:26:33 Homebridge homebridge[3775]: [2019-4-8 21:26:33] [FibaroHC2] Getting value from device: 233 parameter: Lock Current State Apr 08 21:26:33 Homebridge homebridge[3775]: [2019-4-8 21:26:33] [FibaroHC2] Getting value from device: 273 parameter: Lock Current State

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ilcato/homebridge-Fibaro-HC2/issues/136#issuecomment-480974811, or mute the thread https://github.com/notifications/unsubscribe-auth/AsX6ZtyyrgH1nBol5HXrStZbslu1hXF0ks5ve5kggaJpZM4ap3Dj .

Krillle commented 5 years ago

The locks needs 2x 360° turns. But here indeed is probably the reason why Siri has a problem opening:

Opening the door at home includes one more turn approx 270° to unlatch the second bolt (German standard outer door). This bolt is held for 3 seconds before it is released and the opening operation is finished. (Here is an example of this operation. Old Danalock but same procedure: youtu.be/HBdI2Jt8C1I) The full cycle takes approx. 7.5 seconds.

Unlocking the door in office does not include the additional unlatching, so no additional 270° + 3 seconds wait. This takes approx 4 seconds.

So we need two different timeouts for opening and closing. And opening timeout it is dependent on if opening the second latch is included or not.

ilcato commented 5 years ago

Not sure to understand, unfortunately I do not have such a device. @MindaugasRam, @carlittoer, @Krillle can you discuss and test different values on the delays in in rows 40,41 of dist/getFunctions.js and check if a single configuration is suitable for all the models ? Maybe the 4s of @carlittoer setup?

Krillle commented 5 years ago

@ilcato The issue is: Additional to unlocking the lock, optionally the latch/dead bolt can be pulled back for a given amount of time. For an example see video above: youtu.be/HBdI2Jt8C1I . The duration of dead bolt being pulled back can be set in the Danalock app, means it is variable.

Besides that, unlocking of the lock sometimes takes a little longer than 4 seconds.

This means: A) The timeouts should be set individually for opening and closing b) The timeout for opening the lock should be customizable in the config.json

In my configuration i suppose the timeout would be 4 seconds for locking and 8 seconds for unlocking (including holding deadbolt open for 3 seconds).

ilcato commented 5 years ago

@Krillle, @MindaugasRam, @carlittoer in the 2.2.3 version you can specify the delays in config.json. Please try tinkering with it and understand if each of you can find a suitable config.

Krillle commented 5 years ago

@ilcato This is great. Thank you!

Krillle commented 5 years ago

Can you please give a short explanation what these two values are specifying exactly?

Krillle commented 5 years ago

I change both values to "7", but no change.

"LockCurrentStateDelay": "7",
"LockTargetStateDelay": "7"

Response from Siri is given after the lock has stopped operating now. Nevertheless the is confirming the locking as successful, but still claims tat opening would not be possible. So no change.

What's weird: Home App is now sending an additional status Notification before the lock starts operating.

ilcato commented 5 years ago

@Krillle these values delay the time at which a response to HomeKit is given allowing the correct status change in Fibaro Home Center. When the seconds specified are elapsed a query to Fibaro Home Center is executed and the response to HomeKit is returned. Please check when the status of the lock change in Fibaro Home Center starting from the command asked in HomeKit. @MindaugasRam, seems to me that 2 second is right for you ? Correct? @carlittoer, what's your delay?

Krillle commented 5 years ago

@ilcato With delay of 2 seconds I get a positive response when closing the lock and also when opening the lock wich simply unlocks (without additionally holding back the bolt).

But for the one which is holding back the bolt I get a negative reply when opening, even with a delay of 10 seconds. Homecenter is showing the status already as open after 4 seconds, while the bolt is still held back. So this doesn't seem to be the reason while opening lock does not give a positive response.

But in the end I can live with that. :-)

ilcato commented 5 years ago

Too much cases for me to understand without testing a real physical device.

carlittoer commented 5 years ago

Tested this with both values at 8 seconds. It's working properly.

carlittoer commented 5 years ago

Hi again all !

Since the last fix (delay of 8 secs), I've been noticing a slower response from the home app to show the device statuses. After some tests, it appears that the home app is waiting the same 8 secs to show the devices statuses (stuck on updating...).

Anything can be done for the lock device only ? Remember, the issue was Siri's incorrect response when locking / unlocking the lock, not the actual home app switch.