search

iliazeus / iso2god-rs

A command-line tool to convert Xbox 360 ISOs into a Games-On-Demand file format. For Linux, Windows and MacOS.
MIT License
77 stars 6 forks source link

Multi Disc games overwrite previous disc #6

Closed thomasbra1 closed 1 year ago

thomasbra1 commented 1 year ago

The XBOX360 has some games that span more than one disc. They share the same title id. Given the structure of the GOD output is to use the title id as the folder name disc 2 will overwrite disc 1 and so on.

I only use verified redump images for reporting issues.

professor-jonny commented 1 year ago

I believe you are mistaken as those games would be un installable via the native NXE format if that were the case.

Many multi disk games have a content folder that is to be installed using the on disk installer and the other disk is to be installed via the dash as normal.

The folder structure should be something like: content\545407F2\00007000 and the data will be stored in content\545407F2\0000D000

can you list/ provide a link to a title that has this issue?

thomasbra1 commented 1 year ago

I have attached a screenshot of the one I have seen. It may or may not be a one off. GOD1 = Disc 1 , GOD2 = Disc 2 Selection_042

thomasbra1 commented 1 year ago

Out of curiosity I converted them with the original windows version and below are the results. It creates a long hex number for each. No idea how it calculates it but I did a second run and it was the same.

Selection_045

professor-jonny commented 1 year ago

That is correct there is two data directorys under 00007000 there is two disks present.

iliazeus commented 1 year ago

The original version computes a needlessly complicated sha-1 hash of some title and media info. iso2god-rs used to have the same behavior, but the resulting paths were often too long for (my installation of) Aurora dashboard to handle when copying from a USB stick. So I've decided to shorten them, but ended up with the issue you described.

This should now be fixed in v1.4.8 by using the media id for the last component of data paths.