search

imjp94 / gd-plug

Minimal plugin manager for Godot
MIT License
209 stars 15 forks source link

Publish new release for godot3 that includes "Enclose directories in command with double-quote" #17

Closed mizutani256 closed 1 year ago

mizutani256 commented 1 year ago

Probably surrounding the dest path on _GitExecutable.clone() with quotes should fix it.

imjp94 commented 1 year ago

Can you share your commands and the output? As the path were wrapped in quotes since #7

mizutani256 commented 1 year ago

My bad, I should have checked the version I was using. I'm on tag 0.1.1 because we use Godot 3, but I see that the branch for Godot 3 also has the fix already. Sorry for that.

In which case, I guess what I actually need is a new release for Godot 3. I can open a new issue for that and close this one.

I know we could just use the Godot 3 branch but we prefer having dependencies with stable versions and we are not in a hurry since this problem is not breaking anything right now.

imjp94 commented 1 year ago

I see, we can just rename this issue. I will make a new release 0.1.2, after I port some fix from master

imjp94 commented 1 year ago

Just released 0.1.2

mizutani256 commented 1 year ago

Thanks a lot!!