Closed Jack-023 closed 1 day ago
Thanks for the contribution!
However, I will have to wait until https://github.com/godotengine/godot/pull/93889 actually merged into Godot master branch. And, automated migration has to be implemented as well, since it break compatibility with previous version
Why does this change depend on https://github.com/godotengine/godot/pull/93889? In the current Godot release you can enable debug/gdscript/warnings/exclude_addons
(enabled by default) which will stop anything in res://addons/
from triggering warnings.
I didn't consider automated migration since I had been deleting the .plugged
directory after running installs to get rid of the warnings :sweat_smile:. Migrating is obviously pretty straightforward to do manually but I am not sure how I would go about setting that up in an automated way.
Oh, I didn't know debug/gdscript/warnings/exclude_addons
exist. Then, it's good.
Automated migration is necessary for a smooth user experience, otherwise, the old .plugged
will be taking out memory in users' project without any purpose and users may not know it should be removed.
It's ok, I can take over from here. But, I don't have time to work on it yet, so it gonna takes a while before this PR can be merged.
FYI in case you decide to use this as a starting point when you pick this up. Something seems to have changed in Godot that has caused this PR to break. It isn't moving files from addons/gd-plug/.plugged
after cloning them any more.
Closing this as #37 has fixed the issues with this PR.
Moving the dir here stops gdscript warnings from triggering on addon code. The Godot team have indicated that they will only support disabling warnings in this directory as it is the only place third party code should be placed.
This change addresses #32, following the discussion there and at https://github.com/godotengine/godot/pull/93889