inbo / alien-species-portal

Portal for alien and invasive species indicators
MIT License
0 stars 0 forks source link

Trias package >= 2.0.3 #32

Closed SanderDevisscher closed 1 year ago

SanderDevisscher commented 1 year ago

Describe the bug When building the app using docker I get the following error:

> [22/23] RUN R -q -e "roxygen2::roxygenize('alienSpecies'); install.packages(pkgbuild::build('alienSpecies'), repos = NULL, dependencies = FALSE)":
#26 0.649 > roxygen2::roxygenize('alienSpecies'); install.packages(pkgbuild::build('alienSpecies'), repos = NULL, dependencies = FALSE)
#26 1.351 ℹ Loading alienSpecies
#26 3.672 Error in load_imports(path) : The package `trias` (>= 2.0.3) is required.
#26 3.672 Calls: <Anonymous> ... load_imports -> deps_check_installed -> check_installed
#26 3.672 Execution halted

To Reproduce Steps to reproduce the behavior:

  1. Go to Mockup - branch
  2. Fetch branch
  3. run devtools::build("alienSpecies")
  4. in powershell run docker build -t openanalytics/r-base .
  5. See error

Expected behavior succesfull build in docker

Additional context Building in R works like it should

SanderDevisscher commented 1 year ago

See readme in mockup branch

SanderDevisscher commented 1 year ago

The readme in the mockup branch is outdated since the packamon package is no longer available for R. Using devtools::build() instead yields the same error.

mvarewyck commented 1 year ago

Your steps for building the docker image are correct. You don't need the R package packamon for that.

Normally trias should get installed from github: https://github.com/inbo/alien-species-portal/blob/mockup/Dockerfile#L158 I guess something went wrong a bit earlier in the docker build.

(I'm running the docker build right now to see what goes wrong, but it takes a while)

mvarewyck commented 1 year ago

@SanderDevisscher Can you try again with 981ddb8f22cb44173817d3888b673910c29b8f0b

SanderDevisscher commented 1 year ago

Building in docker seems to get past point of previous error

SanderDevisscher commented 1 year ago

Builden in docker was succesfull

SanderDevisscher commented 1 year ago

It also runs in docker