search

incf-nidash / nidm-specs

Neuroimaging Data Model (NIDM): describing neuroimaging data and provenance
nidm.nidash.org
Other
33 stars 30 forks source link

new UpdateExpTermReadme.py file #468

Closed khelm closed 5 years ago

khelm commented 6 years ago

Created a modified UpdateTermReadme.py file for NIDM-Exp called UpdateExpTermReadme.py under the nidm-experiment path. This will require changes to scripts/refresh.py, which I'm leaving for @cmaumet

cmaumet commented 6 years ago

Hi @khelm! Thanks for this update!

I've just added a commit to call your new UpdateExpTermReadme.py as part of refresh.py (cf. https://github.com/incf-nidash/nidm-specs/pull/468/commits/16d1ef46f3793c75c809100d404641a78488d38d for a view of the changes).

You should be able to pull those change with git pull origin create-exp-curation-page (provided that origin points to your khelm's fork).

Currently the call to UpdateExpTermReadme within refresh.py fails with the following error:

$ python scripts/refresh.py 
Traceback (most recent call last):
  File "scripts/refresh.py", line 47, in 
    main()
  File "scripts/refresh.py", line 31, in main
    UpdateExpTermReadme.main()
  File "/path/to/nidm-specs/scripts/../nidm/nidm-experiment/scripts/UpdateExpTermReadme.py", line 249, in main
    updateReadme.update_readme(readme_file)
  File "/path/to/nidm-specs/scripts/../nidm/nidm-experiment/scripts/UpdateExpTermReadme.py", line 224, in update_readme
    curation_legend = self.create_curation_legend(order)
  File "/path/to/nidm-specs/scripts/../nidm/nidm-experiment/scripts/UpdateExpTermReadme.py", line 119, in create_curation_legend
    CURATION_LEGEND[color]+";\n"
KeyError: ''

Are you happy to follow up on investigating this?

khelm commented 6 years ago

Yes, thanks. I will follow up. I wanted to make sure that refresh.py was calling UpdateExpTermReadme.py correctly before I spent time on that error.

cmaumet commented 5 years ago

Great!! So happy to see the curation page implemented for NIDM-experiment: https://github.com/incf-nidash/nidm-specs/blob/master/nidm/nidm-experiment/terms/README.md.

khelm commented 5 years ago

Yes, thanks for taking the time so we could sort out the pelican issue at the hackathon!