search

incf-nidash / nidm-specs

Neuroimaging Data Model (NIDM): describing neuroimaging data and provenance
nidm.nidash.org
Other
33 stars 30 forks source link

Retrigger tests with cast removed from nidmresults library #488

Open cmaumet opened 4 years ago

cmaumet commented 4 years ago

This a companion PR to https://github.com/incf-nidash/nidmresults/pull/59. To retrigger the tests and check that removing the cast as suggested by @khelm does not cause backward compatibility issues.

cmaumet commented 4 years ago

@khelm: the tests pass although we do get some missing links -- e.g. to 'Map' in nidm_results_dev.html.

khelm commented 4 years ago

Thanks @cmaumet - any idea why Map doesn't show up? This issue arose because there are evidently some non-printing unicode characters in the files that I've been working to eliminate, with only partial success.

cmaumet commented 4 years ago

@khelm - I think the terms that do not show up are those that are used inside a definition (and were surrounded by quotes so that they would be picked up as terms).

Do you have an example of where the cast is making the tests fail on nidm-experiment updates? Is https://github.com/incf-nidash/nidm-specs/pull/487 a good example? Or should I be looking somewhere else?

khelm commented 4 years ago

@cmaumet Not sure how I missed this... Yes, #487 is where the issue arises. Thanks!