search

incf-nidash / nidm-specs

Neuroimaging Data Model (NIDM): describing neuroimaging data and provenance
nidm.nidash.org
Other
33 stars 30 forks source link

Travis Tests failing due to jsonld.py #491

Closed khelm closed 4 years ago

khelm commented 4 years ago

@dbkeator @cmaumet - The latest code fixes that I've pushed have failed for reasons that don't seem to have anything to do with the fixes I've made. The issue seems to be with a syntax error in jsonld.py. It fails in six different places all seemingly related to nidm-results, but all are the same call to jsonld.py

The Travis report is here

Any ideas?

khelm commented 4 years ago

Also, I've locally run create_expe_specifications.py and refresh.py and neither returned any errors.

cmaumet commented 4 years ago

Hi @khelm! Yes, the problem was not related to your edits. The error was an effect of the (different) versions of the libraries pyld and rdflib-jsonld used by Travis. I've added two commits to force older versions and now the tests pass at https://github.com/incf-nidash/nidm-specs/pull/490.

khelm commented 4 years ago

Thanks very much @cmaumet, I appreciate you looking into this! I will re-run the tests on my last commit.

cmaumet commented 4 years ago

Hi @khelm! Happy to help :) I don't know if you have seen but in order to test, I've added commits directly into your branch (cf. https://github.com/incf-nidash/nidm-specs/pull/490). You will need to pull these first. Provided that origin points to your fork, you could use:

git pull origin update_exp_specs_file
khelm commented 4 years ago

Hi @cmaumet , thanks I will test this out today.

khelm commented 4 years ago

@cmaumet and @dbkeator - Travis checks now run successfully and all latest work has been merged. Thanks!