fix(cli): improper MST removal when using CLI prompt, new arch compat - Githubissues

infinitered / ignite

Infinite Red's battle-tested React Native project boilerplate, along with a CLI, component/model generators, and more!

MIT License

17.48k stars 1.38k forks source link

fix(cli): improper MST removal when using CLI prompt, new arch compat #2785

Closed frankcalise closed 1 week ago

frankcalise commented 1 week ago

Please verify the following:

[ ] yarn test jest tests pass with new tests, if relevant
[ ] yarn lint eslint checks pass with new code, if relevant
[ ] yarn format:check prettier checks pass with new code, if relevant
[ ] README.md (or relevant documentation) has been updated with your changes

Describe your PR

As described by @markrickert, when using the prompts to set the following scenario (yarn, no demo, git repo, install deps, no MST, expo router, new arch) - MST was not removed properly
With proper MST removal, the lint step failed inside of the ReactotronConfig leaving in clear from @/utils/storage which we were no longer needing, so I added the proper MST removal directives around that)
Also occurs in the main _layout file when in the expo-router scenario
When opting into the new architecture, some libraries need to be updated (for example react-native-mmkv from 2 to 3), the new command has updates for this

lindboe commented 1 week ago

Should we add more tests to prevent this from breaking again? Like fully generating and running lint on these permutations.

I know it adds more time, but it also seems useful since it's easy to accidentally break. (Side note: I realized today we should probably break out the tests that generate projects into different files, since that allows Jest to run them in parallel.)