Fix: Web rendering issues and welcome screen layout issue - Githubissues

infinitered / ignite

Infinite Red's battle-tested React Native project boilerplate, along with a CLI, component/model generators, and more! 9 years of continuous development and counting.

MIT License

17.74k stars 1.4k forks source link

Fix: Web rendering issues and welcome screen layout issue #2809

Open fpena opened 1 month ago

fpena commented 1 month ago

Please verify the following:

[x] yarn test jest tests pass with new tests, if relevant
[x] yarn lint eslint checks pass with new code, if relevant
[x] yarn format:check prettier checks pass with new code, if relevant
[x] README.md (or relevant documentation) has been updated with your changes
[x] If this affects functionality there aren't tests for, I manually tested it, including by generating a new app locally if needed (see docs).

Describe your PR

Closes #2807

This PR solves 3 issues:

Within the Screen component, KeyboardAvoidingView is crashing in web. It was replaced by a normal ScrollView.
Within the useHeader hook and web, useLayoutEffect was creating a rendering loop. It is replaced by useEffect.
Within the welcome screen and specifically in Spanish, the text clashes with the face icon. This was fixed.

Screenshots (if applicable)

Before	After
https://github.com/user-attachments/assets/25330c6a-e93a-41be-87ea-b8d22779d0a2	https://github.com/user-attachments/assets/7a8a4cf3-bac4-4a6e-b3b8-e0741135bb4f